From owner-svn-src-all@FreeBSD.ORG Sun Oct 19 12:47:18 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA01D1065693; Sun, 19 Oct 2008 12:47:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 7ABFE8FC17; Sun, 19 Oct 2008 12:47:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1KrXgh-000MpU-An; Sun, 19 Oct 2008 15:47:15 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m9JClCfO075660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 19 Oct 2008 15:47:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id m9JClC30018964; Sun, 19 Oct 2008 15:47:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id m9JClCLA018962; Sun, 19 Oct 2008 15:47:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 19 Oct 2008 15:47:12 +0300 From: Kostik Belousov To: Roman Divacky Message-ID: <20081019124711.GR7782@deviant.kiev.zoral.com.ua> References: <200810191002.m9JA2Q5N040016@svn.freebsd.org> <20081019124054.GA25779@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tHTlq+1i+J693gRP" Content-Disposition: inline In-Reply-To: <20081019124054.GA25779@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1KrXgh-000MpU-An c75109500eb0bfdafc272536aeee085c X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184058 - in head/sys: amd64/linux32 compat/linux i386/linux X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Oct 2008 12:47:18 -0000 --tHTlq+1i+J693gRP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 19, 2008 at 02:40:54PM +0200, Roman Divacky wrote: > On Sun, Oct 19, 2008 at 10:02:26AM +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Sun Oct 19 10:02:26 2008 > > New Revision: 184058 > > URL: http://svn.freebsd.org/changeset/base/184058 > >=20 > > Log: > > Correctly fill siginfo for the signals delivered by linux tkill/tgkil= l. > > It is required for async cancellation to work. > > =20 > > Fix PROC_LOCK leak in linux_tgkill when signal delivery attempt is ma= de > > to not linux process. > > =20 > > Do not call em_find(p, ...) with p unlocked. > > =20 > > Move common code for linux_tkill() and linux_tgkill() into > > linux_do_tkill(). > > =20 > > Change linux siginfo_t definition to match actual linux one. Extend > > uid fields to 4 bytes from 2. The extension does not change structure > > layout and is binary compatible with previous definition, because i386 > > is little endian, and each uid field has 2 byte padding after it. > =20 > does it fix the test case Nicolas provided? It didnt for me when I tried > this patch... As far as I got it from conversation with Dmitry, cancellation still does not work. This patch is a required cleanup anyway. >=20 > > Reported by: Nicolas Joly >=20 > might be of some interest for someone... njoly of netbsd :) Point taken. --tHTlq+1i+J693gRP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkj7LE8ACgkQC3+MBN1Mb4g6+gCfUZxLcpHfhZmWzsUvrJksEccF 8koAoIZm6EXhtnLY5LnvHx7kG6b9l1Eb =6MrZ -----END PGP SIGNATURE----- --tHTlq+1i+J693gRP--