From owner-svn-src-head@freebsd.org Wed May 30 13:47:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70DDBEFDF3A; Wed, 30 May 2018 13:47:55 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C79E383F43; Wed, 30 May 2018 13:47:54 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lf0-x241.google.com with SMTP id o9-v6so4396777lfk.1; Wed, 30 May 2018 06:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=olEFy6mRCIxFynFBzWRAqLB46LpE0f/YMO+jDiuS7rk=; b=o+QmquWFjEXnyj9n8Gf5GIGrWYJmFBFbVd75a1DNCJTdwnext++cV3pwzzhpEAJ5En ZOKe0u8LObRYTKyGEryMbC2BKosWnaQSq7ZE0/8aLQPCQFNXETe4adRcB6XyLLmfTNXH BslhNVnPx8vyb3ipVU7XEdLuoQ6mREVfos8Q0AzxRUAf1YtL2vYG2XWQ/2qLbPTEswar CG6pGkhHa4cgdZzgdfU7gQBTXjxh/Mi8xwj5quignUSfGXRCGksUgQ3GGHlAjTOvt1Dt CN0fesu8FKetbMZnH6LXkff5ct57PLpIuMGRxupLGWswbf5FbTaQmIy0i1bKi1b+izVM Ey5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=olEFy6mRCIxFynFBzWRAqLB46LpE0f/YMO+jDiuS7rk=; b=FQgPnUd71VXGBZuMlHwiqmQPpcLjW+Eosewuh9v0KbodTGznSxUuUfGxNyGmV1fbel 2+7qCktl5K5T2s5wqLLeWAolQZUtpQrBr0L4PHfTknuUpLEe6OcjFinYR2+eLMGPpShc e1Wr71m/dCRckLFg6pyRv8bestSD5uCIjO5YdgXqRtVJ9Hr6JiKioxTYxBM1e2vv2+Ln 9d9cQ4/StZ89N6BqFd1kKHyknSR+QWXrC7wc3BHlo2CZmKhE1934XDpMVPfMfY1ZDYGl esrFMhAQuBA+YKpr/QzKDBLDiBLChIg0kkgXxxBEaiQc7W1WmxuUPAnR2xLUCBk8SmDc J1rA== X-Gm-Message-State: ALKqPwctLHSmXVraDghLmOnHPXoPhOB6VcOLMvLubznTbaDnAX1TKY60 /lCmsZEiuUIp3mCnThW5Z0v/2csO8+kcnxwDzk0= X-Google-Smtp-Source: ADUXVKLFbKxEEBPHfcWHUrjEDwI4x0NbXgEPgL/rV70HxzmjSHLrT3k/zZhGMJmpa2KEnEfR0Le6xK2is1brRTk+QcU= X-Received: by 2002:a19:51db:: with SMTP id g88-v6mr1831237lfl.78.1527688069464; Wed, 30 May 2018 06:47:49 -0700 (PDT) MIME-Version: 1.0 Sender: chmeeedalf@gmail.com Received: by 2002:a2e:3a13:0:0:0:0:0 with HTTP; Wed, 30 May 2018 06:47:48 -0700 (PDT) In-Reply-To: <25bd4319-6d7f-e668-88e4-4c3adbc1e8e9@freebsd.org> References: <201805300241.w4U2fmvB033942@repo.freebsd.org> <25bd4319-6d7f-e668-88e4-4c3adbc1e8e9@freebsd.org> From: Justin Hibbits Date: Wed, 30 May 2018 08:47:48 -0500 X-Google-Sender-Auth: eZG7tQrEmeCwrxjZJGmjPc90l1g Message-ID: Subject: Re: svn commit: r334365 - head/sys/dev/pci To: Peter Grehan Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 13:47:55 -0000 On Wed, May 30, 2018 at 4:42 AM, Peter Grehan wrote: >> PCIe only permits 1 device on an endpoint, so some devices ignore the >> device >> part of B:D:F probing. Although ARI likely fixes this, not all >> platforms >> support ARI completely or correctly, so some devices end up showing up >> 32 >> times on the bus. > > > I think this might have broken bhyve - a fake PCIe capability is put on the > root port so that guests will use MSI/MSI-x, but otherwise it looks like > parallel PCI. Not exactly spec-compliant, but then neither is most of the > world of PCI/PCIe. > > It may be worth #ifdef'ing this with powerpc. > > later, > > Peter. I can special case i386 and amd64, but this change should (eventually) remove the majority of the current special case overrides for alternative architectures. I think it'd be better to have a bhyve root bridge driver that itself overrides pci_maxslots(), and have the 'compliant' path be the common. Thoughts? - Justin