From owner-freebsd-sparc64@FreeBSD.ORG  Wed Nov  5 04:23:16 2008
Return-Path: <owner-freebsd-sparc64@FreeBSD.ORG>
Delivered-To: freebsd-sparc64@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 933031065672;
	Wed,  5 Nov 2008 04:23:16 +0000 (UTC) (envelope-from scf@FreeBSD.org)
Received: from mail.farley.org (farley.org [67.64.95.201])
	by mx1.freebsd.org (Postfix) with ESMTP id 5A7C38FC29;
	Wed,  5 Nov 2008 04:23:16 +0000 (UTC) (envelope-from scf@FreeBSD.org)
Received: from thor.farley.org (HPooka@thor.farley.org [192.168.1.5])
	by mail.farley.org (8.14.3/8.14.3) with ESMTP id mA540NOH055437;
	Tue, 4 Nov 2008 22:00:23 -0600 (CST) (envelope-from scf@FreeBSD.org)
Date: Tue, 4 Nov 2008 22:00:22 -0600 (CST)
From: "Sean C. Farley" <scf@FreeBSD.org>
To: freebsd-current@FreeBSD.org
In-Reply-To: <20081105013120.8FAAF73039@freebsd-current.sentex.ca>
Message-ID: <alpine.BSF.2.00.0811042123410.15712@thor.farley.org>
References: <20081105013120.8FAAF73039@freebsd-current.sentex.ca>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-Spam-Status: No, score=-4.3 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00
	autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail.farley.org
Cc: freebsd-sparc64@FreeBSD.org
Subject: Re: [head tinderbox] failure on sparc64/sun4v
X-BeenThere: freebsd-sparc64@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the Sparc <freebsd-sparc64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>, 
	<mailto:freebsd-sparc64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sparc64>
List-Post: <mailto:freebsd-sparc64@freebsd.org>
List-Help: <mailto:freebsd-sparc64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2008 04:23:16 -0000

On Tue, 4 Nov 2008, FreeBSD Tinderbox wrote:

*snip*

> cc -O -pipe  -DLIBC_SCCS -DINET6 -I/src/lib/libutil -I/src/lib/libutil/../libc/gen/ -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wno-pointer-sign -c /src/lib/libutil/gr_util.c
> cc1: warnings being treated as errors
> /src/lib/libutil/gr_util.c: In function 'gr_dup':
> /src/lib/libutil/gr_util.c:154: warning: cast increases required alignment of target type
> *** Error code 1

Does the following patch fix this warning (due to r184635) correctly?
It should align the (char **) pointer correctly within the allocated
buffer.  The (void *) cast is necessary because gcc is not able to
detect that the alignment was fixed.  Better solutions are welcome.

http://www.farley.org/freebsd/tmp/libutil.patch

Sean
-- 
scf@FreeBSD.org