From owner-freebsd-current  Thu Jan  2 20:55:44 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id UAA28721
          for current-outgoing; Thu, 2 Jan 1997 20:55:44 -0800 (PST)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id UAA28716
          for <current@freebsd.org>; Thu, 2 Jan 1997 20:55:40 -0800 (PST)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id PAA18846; Fri, 3 Jan 1997 15:53:58 +1100
Date: Fri, 3 Jan 1997 15:53:58 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199701030453.PAA18846@godzilla.zeta.org.au>
To: current@freebsd.org, jb@cimlogic.com.au
Subject: Re: MOD_DECL in lkm.h
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

>Shouldn't the MOD_DECL macro in lkm.h also have:
>
>static int name ## _stat __P((struct lkm_table *lkmtp, int cmd)); \
>
>so that the status function has a prototype defined before it is used?

No, because it causes annoying warnings for modules that don't have a
stat function when such modules are compiled with -Wunused.

This reminds me that MOD_VFS() and MOD_SYSCALL() are missing declarations
for the xxx_mod functions.  Their interfaces only pass the stringified
name of the function, so they can't declare things.  VFS_SET() could
easily declare the entry point, but it would be more consistent to
declare everything in MOD_XXX().

Bruce