From owner-freebsd-arch@FreeBSD.ORG Tue Sep 8 13:38:00 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 280FD106568D; Tue, 8 Sep 2009 13:38:00 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id EB1FB8FC22; Tue, 8 Sep 2009 13:37:59 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 88A3E46B3B; Tue, 8 Sep 2009 09:37:59 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id CB21F8A01D; Tue, 8 Sep 2009 09:37:58 -0400 (EDT) From: John Baldwin To: freebsd-arch@freebsd.org Date: Tue, 8 Sep 2009 09:36:37 -0400 User-Agent: KMail/1.9.7 References: <200909031340.n83Defkv034013@svn.freebsd.org> <20090904.161634.-217944108.imp@bsdimp.com> <3bbf2fe10909041546y2b5633e1ue063955568df1a06@mail.gmail.com> In-Reply-To: <3bbf2fe10909041546y2b5633e1ue063955568df1a06@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200909080936.37603.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 08 Sep 2009 09:37:58 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.6 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Attilio Rao , arch@freebsd.org Subject: Re: NEWBUS states (was Re: svn commit: r196779 - in head/sys: kern sys) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2009 13:38:00 -0000 On Friday 04 September 2009 6:46:03 pm Attilio Rao wrote: > We all agreed the one-state was the better option but it can't be done > in this way because of the device_is_attached() used in the detach > virtual functions. Using just one transition state will break > device_is_attached() in those parts. > The right fix, as pointed out in other e-mails, is to not use > device_is_attached() in detach virtual functions. The better fix, in > my idea would involve: > - replace the device_is_attached() usage in detach virtual functions, > with a more functional support > - use one-state transition > > But that is just too much job to push in before then 8.0-REL and if > that would mean to not commit a patch and make impossible a future > MFC, I prefer to go with a lesser-perfect-but-still-working-approach. Wait, all you need to MFC is the change to the enum. Fixing the various detach routines does _not_ have to be in 8.0. That could be merged after the release. -- John Baldwin