Date: Sat, 15 Apr 2006 01:20:59 +0900 (JST) From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: sos@freebsd.org Cc: acpi@freebsd.org, current@freebsd.org Subject: Re: CFR: ACPI Dock driver Message-ID: <20060415.012059.130244002.iwasaki@jp.FreeBSD.org> In-Reply-To: <1145029263.912.4.camel@sos.deepcore.dk> References: <20060414.180622.30189283.iwasaki@jp.FreeBSD.org> <20060414.233013.41626908.iwasaki@jp.FreeBSD.org> <1145029263.912.4.camel@sos.deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
> --- ata-all.c 31 Mar 2006 08:09:04 -0000 1.271
> +++ ata-all.c 14 Apr 2006 15:39:20 -0000
> @@ -277,8 +277,8 @@
> if (!dev || !(ch = device_get_softc(dev)))
> return ENXIO;
>
> - /* wait for the channel to be IDLE before entering suspend mode */
> - while (1) {
> + /* wait for the channel to be IDLE or detached before suspending */
> + while (ch->r_irq) {
> mtx_lock(&ch->state_mtx);
> if (ch->state == ATA_IDLE) {
> ch->state = ATA_ACTIVE;
>
> That I'll gladly commit for you instead...
Yes, This have also the same effect. I prefer this.
Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060415.012059.130244002.iwasaki>