From nobody Wed Sep 24 22:27:13 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cXBLB5lC9z68Xph for ; Wed, 24 Sep 2025 22:27:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cXBLB3kfkz3N8Q for ; Wed, 24 Sep 2025 22:27:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-330469eb750so368713a91.2 for ; Wed, 24 Sep 2025 15:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758752844; x=1759357644; darn=freebsd.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=81viuf+VS6tPZdbhBDl4HJTnobTf6z9SnW53V8IjgRE=; b=myaN/QY6q82j1OBoOHRCfH9vBa56aAbS4enQrcwxYjUk9TmbMiN05tYN874XPdeLBL C2YCsUAD0hyQIn/DdSfaKdqhXDvvB/+hJEEB6VwZmNul3OCDmXSq4PtpqBzZwiZQbYCj 6ew5svZEpFK43ROerP/Jy4hH8S3Q6unLxfCeYaLnl45Kr1mx/Xrnnte3iKxyFhBSw84s eDLKfzsxcZA7nQdzVWZE6p1WFQCET7rtEewAT8fCUgCy5BLMzjfF5GxBMa0N3TPxxPA7 5WeCyLp21gAjHdNz0K2iSFbsaMiAIW3z0+ZKnlzd7jtJm55lVWDu02FpctXAsG2w2KKt 4YhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758752844; x=1759357644; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=81viuf+VS6tPZdbhBDl4HJTnobTf6z9SnW53V8IjgRE=; b=rTfc99xv5nS3n+MaN+Hp8GNNGFbYKMPMgVjDnl8DSUJaEJRuYqL/VqbdRtKNyDRSE/ tFdm0MyeR0XmYe1TsQGYB0J2SKcJObugVAkI7H8rt05HuTu8s/QvSbcWzCWBPal6BRD2 wUCt4jyw+qXz8SN5GNJn+gIS0Osg8/EJnJqWMky3s0oF/ZFHeA9RXYgdUkY6jbZ8trIn q3Df8n5PyasBCCwdNUdmtLUe4MdEZUX05dx6xgUKBBENVVdT45TqtzVIKvrLTGvHRKJS oqaza3R+JAUAAQNKp+HbbvZOSPMDIeFII1Uw9nqcMTq1GR7h3aXpnemrYcghL1zqB2YI li8w== X-Forwarded-Encrypted: i=1; AJvYcCUnRPCa0BLhZOy8vZLgaj5m1S84Hl/R8DAiOk3aYCXHV7M7HLcbk3LktwuS411ie2QTIPq4nDtmhYRYRCg5K+sHCBCQ4w==@freebsd.org X-Gm-Message-State: AOJu0YwLybS4MZ2mHqD/3Xa8Q2dCN0KtbXuUISIT179uLMsEyDG1aC82 HwxM+DC+l0u3S01jIb7CakyhRrbg25FNZ4c+s8bwn7VEaVcfJv0iCeRxiQ8vWuVk X-Gm-Gg: ASbGncsyuWrR0SmVfWRjC82hiRaumY/FMSBh0c8zs+xrwSgxddCYhaM8JJmVgLXlQTN XVMPyzJz7BQZoyz5jwQJex2PowEhB3I7GP54TB8v3UukO+w1CrVOsCkB82mQjc3OAGQFPA4IeL8 3UDiPdf/9fHsXXl/Z4os64b0ptv4sunk05FZzPGAVD9CFztU3eXR+L87bGi3P+VzIXJQ0dyFPxN 4AmAaYa/tP6a1DykbFM1rvDopexn5V1eK+ZAAuZA9QviBU715KLEdCTs3FfMdkLRSAvzrPffLOW nKlHflGBjjuU1KHFfDqNU1KX52RHczyErgNO3638TUFuXtIw1D2IN7q3/m9qdjuZZwLskSwgj+j fxY4TVBnGU8L42CZ1uJYm0vLTMbHVVXZ4xZH9/ITiMlIkUzMF3eT/0sFTCQ== X-Google-Smtp-Source: AGHT+IGj/mnTdNunntkFhu5T5OYV/engYbKCDESQMvWeZh/bZdwdcesEESScq3xRnOkoepmx1Dp4iA== X-Received: by 2002:a17:90b:4a92:b0:32e:e18a:368c with SMTP id 98e67ed59e1d1-3342a257491mr1189443a91.7.1758752844332; Wed, 24 Sep 2025 15:27:24 -0700 (PDT) Received: from smtpclient.apple ([84.39.151.13]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33473f7bebasm98742a91.13.2025.09.24.15.27.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Sep 2025 15:27:23 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: 2352b89d2f73 - main - nanobsd: Fix regressions from last cleanup From: "Enji Cooper (yaneurabeya)" In-Reply-To: <202509241644.58OGio1p048008@gitrepo.freebsd.org> Date: Wed, 24 Sep 2025 15:27:13 -0700 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9DCA5700-4BD1-4C7C-9510-B0A79D41265E@gmail.com> References: <202509241644.58OGio1p048008@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3826.700.81) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cXBLB3kfkz3N8Q > On Sep 24, 2025, at 9:44=E2=80=AFAM, Warner Losh = wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D2352b89d2f732e3fa33fbd494267f0d4= cb917e51 >=20 > commit 2352b89d2f732e3fa33fbd494267f0d4cb917e51 > Author: Warner Losh > AuthorDate: 2025-09-24 15:43:42 +0000 > Commit: Warner Losh > CommitDate: 2025-09-24 15:43:42 +0000 >=20 > nanobsd: Fix regressions from last cleanup >=20 > c99bb5747f5e changed ( ) grouping into { }, but in these cases we = chdir > and depended on the subshell not changing it for the caller. = Restore the > old behavior. It seems to work w/o this change, true, but the old = code > was intentionally like this. >=20 > Fixes: c99bb5747f5e > Sponsored by: Netflix Thank you for fixing my faux pas Warner :/. I was actually considering = leaving the curly braces in place and just adding ellipses around the = affected instructions (it would have made the sub-shell scope explicit), = but this is a great fix too. -Enji=