Date: Thu, 19 Apr 2001 23:44:56 +0200 (CEST) From: dim@xs4all.nl To: FreeBSD-gnats-submit@freebsd.org Cc: dim@xs4all.nl Subject: ports/26719: net/socks5 port fails to find downloaded distfile Message-ID: <20010419214456.0FBD515351@tensor.xs4all.nl>
next in thread | raw e-mail | index | archive | help
>Number: 26719 >Category: ports >Synopsis: net/socks5 port fails to find downloaded distfile >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 19 14:50:00 PDT 2001 >Closed-Date: >Last-Modified: >Originator: Dimitry Andric >Release: FreeBSD 4.3-RC i386 >Organization: None >Environment: System: FreeBSD tensor.xs4all.nl 4.3-RC FreeBSD 4.3-RC #0: Sat Apr 14 22:24:27 CEST 2001 root@tensor.xs4all.nl:/usr/obj/usr/src/sys/TENSOR i386 >Description: Today I tried building the net/socks5 port. After placing the required distfile socks5-v1.0r11.tar.gz in /usr/ports/distfiles, as the Makefile told me to do first, it still said it couldn't find the distfile: ===> socks5-1.0.11_1 NEC requires that you grab the dist files from their web site at http://www.socks.nec.com/cgi-bin/download.pl . Please make sure you have socks5-v1.0r11.tar.gz in /usr/ports/distfiles and run make again.. (btw, notice the double '.' at the end of the line, caused by including a '.' in the IGNORE macro in Makefile.) This problem is caused by the following line in Makefile: .if !exists(${DISTDIR}/${DISTNAME}${EXTRACT_SUFX}) which is used _before_ ${DISTDIR} and ${EXTRACT_SUFX} are defined (in bsd.port.mk). Therefore the path to the distfile is improperly constructed, and the distfile cannot be found, even when it is put in the right place. >How-To-Repeat: [put socks5-v1.0r11.tar.gz in /usr/ports/distfiles] cd /usr/ports/net/socks5 && make >Fix: The fix is to include bsd.port.pre.mk before the if, and bsd.port.post.mk after it, just as in other ports which require "manual" downloading of distfiles. Here's a patch (also correcting the extranous '.'): --- Makefile.orig Mon Apr 2 12:34:48 2001 +++ Makefile Thu Apr 19 23:35:54 2001 @@ -36,8 +36,10 @@ MAN5= libsocks5.conf.5 socks5.conf.5 CONFIGURE_ENV= LIBS=-lcrypt +.include <bsd.port.pre.mk> + .if !exists(${DISTDIR}/${DISTNAME}${EXTRACT_SUFX}) -IGNORE="NEC requires that you grab the dist files from their web site at http://www.socks.nec.com/cgi-bin/download.pl . Please make sure you have ${DISTNAME}${EXTRACT_SUFX} in ${DISTDIR} and run make again." +IGNORE="NEC requires that you grab the dist files from their web site at http://www.socks.nec.com/cgi-bin/download.pl . Please make sure you have ${DISTNAME}${EXTRACT_SUFX} in ${DISTDIR} and run make again" .endif -.include <bsd.port.mk> +.include <bsd.port.post.mk> >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010419214456.0FBD515351>