Date: Tue, 01 Mar 2016 10:58:34 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r409855 - in head: lang/tcl86 lang/tcl86/files x11-toolkits/tk86 Message-ID: <6C71D4ECCA17E729D8CA7F38@atuin.in.mat.cc> In-Reply-To: <201603010931.u219VhfM013833@repo.freebsd.org> References: <201603010931.u219VhfM013833@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========BACBCBCCC8CAA3B75B5B==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
+--On 1 mars 2016 09:31:43 +0000 Pietro Cerutti <gahr@FreeBSD.org> wrote:
| +TEST_TARGET= do-test
That should not be needed, the fact that you have a do-test target will
have "make test" work the right way.
| +TCLMAN_VARS= INSTALL_TARGET+=install-doc
| +TZDATA_VARS= INSTALL_TARGET+=install-tzdata
| +MODULES_VARS= INSTALL_TARGET+=install-modules
These three should be written as:
TCLMAN_INSTALL_TARGET=install-doc
TZDATA_INSTALL_TARGET=install-tzdata
MODULES_INSTALL_TARGET=install-modules
instead of using the _VARS construct. The porter's handbook do say, in red:
Before using OPT_VARS and OPT_VARS_OFF, see if there is already a
more specific helper available
With a link to the correct section.
| +.include <bsd.port.options.mk>
You can drop this if you use the post-patch-TCLMAN-off: target.
--
Mathieu Arnold
--==========BACBCBCCC8CAA3B75B5B==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJW1WfKXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IOZIP/0QdCnTr3Wp/qmvnPnBdbrmb
XIvd76xHGgZ2ji1yzETAJFnkJOdOI+U2wWJ6LXo0vNKWWPb/nt3w8+1F0zvVpSgv
8zVboU6LnVtZBZH63KoL2VRLru/t7cggmxsUqdyXrGGhzIEwu2OvTfZpP9SOxaYD
Ms4qsDDlzjMPnwAq+v15/KR8xe+h9N1aJEJJBnTMlxUbbSI675l+ks7UYi3dHt1M
Ey2IX3/lafP2qK+1yQa4qN+pXwWZenBAXzWYUcq9nNh1HrVQ9nFr3ad0pTXSTjuq
BaXWEOQhVapU9W/2OK5IP9BoWAuCqWcZ7ym0LCyO1fujpKoprV4oiDZWUZOFJpxv
FAc30fApKpfliZvxl1SD2whV9PiY8nrLCM+0658k3/u1+5IJSuAAf1QG3RBzRHN8
ZQEZ/xYs4eUdGhdwUOxKiTOKKrOBGNFBsMem2HZT8+T/hUbNhCTTOZTQifvdnCXv
Og2btTon7Oinlg9B4jXY8kk7GLfZgQZXU+CU6T8CbBP31tFl2y0X/8U10OiHL9cW
0yFIw93Gd+o7HwaRB9fzKy5aEAxpSz+zQXmGNfOvH/emL2WzBlr2RWz4e6LP4WBS
eYnqQz8wtltdIO/p/ww2q4rWldzAKcPoelASY4zaK34UXgFnhg/1MasXwA+1Og2W
0P6748q36VL/qatipnLy
=xqGQ
-----END PGP SIGNATURE-----
--==========BACBCBCCC8CAA3B75B5B==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6C71D4ECCA17E729D8CA7F38>