From owner-freebsd-bugs Wed Mar 29 00:25:05 1995 Return-Path: bugs-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA11589 for bugs-outgoing; Wed, 29 Mar 1995 00:25:05 -0800 Received: from hda.com (hda.com [199.232.40.182]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA11583 for ; Wed, 29 Mar 1995 00:25:03 -0800 Received: (dufault@localhost) by hda.com (8.6.9/8.3) id DAA02000; Wed, 29 Mar 1995 03:25:05 -0500 From: Peter Dufault Message-Id: <199503290825.DAA02000@hda.com> Subject: Re: kern/281: messages printed when checking CD ROM device too verbose To: pst@Shockwave.COM Date: Wed, 29 Mar 1995 03:25:04 -0500 (EST) Cc: freebsd-bugs@freefall.cdrom.com In-Reply-To: <199503290540.VAA22051@freefall.cdrom.com> from "Paul Traina" at Mar 28, 95 09:40:01 pm X-Mailer: ELM [version 2.4 PL24] Content-Type: text Content-Length: 1137 Sender: bugs-owner@FreeBSD.org Precedence: bulk I know this isn't quite what you'll want, but how about: > (bt0:4:0): "NEC CD-ROM DRIVE:210 1.0" is a type 5 removable SCSI 1 > cd0(bt0:4:0): CD-ROM > cd0(bt0:4:0): NOT READY csi:20,b,0,0 asc:b,0 > could not get size with: > (bt0:4:0): "NEC CD-ROM DRIVE:210 1.0" is a type 5 removable SCSI 1 > cd0(bt0:4:0): CD-ROM drive empty for devices we fully understand. The reason we still have a dangling line is that the driver is in the process of printing out the "CD-ROM [disk size]" line when the interrupt routine reports the undefined (in the SCSI-2 spec) error asc:b ascq:0. When this is something we understand then we can catch it and not log the message. In checking the code I see a buglet. The "drive empty" message is a bit presumptious - all we really know is we can't get the size. That's why I propose to change the message from "drive empty" to "could not get size". Some of checking in the ASC should let us be more explicit, but not in your case. -- Peter Dufault Real Time Machine Control and Simulation HD Associates, Inc. Voice: 508 433 6936 dufault@hda.com Fax: 508 433 5267