Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 May 2012 18:09:47 -0700
From:      Oleg Moskalenko <oleg.moskalenko@citrix.com>
To:        'Garrett Cooper' <yanegomi@gmail.com>, Outback Dingo <outbackdingo@gmail.com>
Cc:        freebsd-current <freebsd-current@freebsd.org>
Subject:   RE: FYI FreeBSD clang build fails on new import of sort
Message-ID:  <031222CBCF33214AB2EB4ABA279428A3011A2C2D1AD3@SJCPMAILBOX01.citrite.net>
In-Reply-To: <CAGH67wS9oJpmp=CGsKRqLwvQuFgJ0CZX%2BO3M7KSEYruoLN29bg@mail.gmail.com>
References:  <CAKYr3zx-UOe63p-q7DTBzy1gzq_Vf0MVZ27RrGOfJ=Z%2BAJ3Dnw@mail.gmail.com> <CAGH67wS9oJpmp=CGsKRqLwvQuFgJ0CZX%2BO3M7KSEYruoLN29bg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Thank you for the error report, we are going to fix it ASAP.

Oleg

> -----Original Message-----
> From: owner-freebsd-current@freebsd.org [mailto:owner-freebsd-
> current@freebsd.org] On Behalf Of Garrett Cooper
> Sent: Sunday, May 13, 2012 5:49 PM
> To: Outback Dingo
> Cc: freebsd-current
> Subject: Re: FYI FreeBSD clang build fails on new import of sort
>=20
> On Sun, May 13, 2012 at 5:02 PM, Outback Dingo <outbackdingo@gmail.com>
> wrote:
> > trying to rerun a clang build of FreeBSD CURRENT fails on new import
> of sort,
> >
> > cat /etc/src.conf
> > WITH_CLANG_IS_CC=3D1
> > make world
> > ---------------------SNIP---------------------------
> > clang -O2 -pipe =A0-DSORT_THREADS -std=3Dgnu99 -Qunused-arguments
> > -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W
> > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes
> > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch
> > -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline
> > -Wnested-externs -Wredundant-decls -Wold-style-definition
> > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c
> > /usr/src/usr.bin/sort/coll.c
> > clang -O2 -pipe =A0-DSORT_THREADS -std=3Dgnu99 -Qunused-arguments
> > -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W
> > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes
> > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch
> > -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline
> > -Wnested-externs -Wredundant-decls -Wold-style-definition
> > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c
> > /usr/src/usr.bin/sort/file.c
> > /usr/src/usr.bin/sort/file.c:601:12: error: format string is not a
> > string literal (potentially insecure) [-Werror,-Wformat-security]
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, g=
etstr(7));
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 ^~~~~~~~~
> > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro
> 'getstr'
> > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n])
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~=
~~~~~~~~~~
> > /usr/src/usr.bin/sort/file.c:942:11: error: format string is not a
> > string literal (potentially insecure) [-Werror,-Wformat-security]
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, getstr(8));
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~
> > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro
> 'getstr'
> > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n])
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~=
~~~~~~~~~~
> > /usr/src/usr.bin/sort/file.c:1279:10: error: format string is not a
> > string literal (potentially insecure) [-Werror,-Wformat-security]
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, getstr(9));
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~
> > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro
> 'getstr'
> > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n])
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~=
~~~~~~~~~~
> > /usr/src/usr.bin/sort/file.c:1295:12: error: format string is not a
> > string literal (potentially insecure) [-Werror,-Wformat-security]
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0errx(2, getstr(10));
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^~~~~~~~=
~~
> > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro
> 'getstr'
> > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n])
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~=
~~~~~~~~~~
> > 4 errors generated.
> > *** [file.o] Error code 1
> >
> > Stop in /usr/src/usr.bin/sort.
>=20
> Yeah... errx(2, getstr(9)) should be errx(2, "%s", getstr(9))...
> -Garrett
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-
> unsubscribe@freebsd.org"



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?031222CBCF33214AB2EB4ABA279428A3011A2C2D1AD3>