From owner-freebsd-current@FreeBSD.ORG Mon May 14 01:09:55 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B93F3106567F for ; Mon, 14 May 2012 01:09:55 +0000 (UTC) (envelope-from oleg.moskalenko@citrix.com) Received: from SMTP02.CITRIX.COM (smtp02.citrix.com [66.165.176.63]) by mx1.freebsd.org (Postfix) with ESMTP id 776448FC21 for ; Mon, 14 May 2012 01:09:55 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.75,582,1330923600"; d="scan'208";a="194629445" Received: from sjcpmailmx02.citrite.net ([10.216.14.75]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/RC4-MD5; 13 May 2012 21:09:48 -0400 Received: from SJCPMAILBOX01.citrite.net ([10.216.4.73]) by SJCPMAILMX02.citrite.net ([10.216.14.75]) with mapi; Sun, 13 May 2012 18:09:47 -0700 From: Oleg Moskalenko To: 'Garrett Cooper' , Outback Dingo Date: Sun, 13 May 2012 18:09:47 -0700 Thread-Topic: FYI FreeBSD clang build fails on new import of sort Thread-Index: Ac0xa4DhISbtapomT2elGVqZ3f2o2gAArAAg Message-ID: <031222CBCF33214AB2EB4ABA279428A3011A2C2D1AD3@SJCPMAILBOX01.citrite.net> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: freebsd-current Subject: RE: FYI FreeBSD clang build fails on new import of sort X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2012 01:09:55 -0000 Thank you for the error report, we are going to fix it ASAP. Oleg > -----Original Message----- > From: owner-freebsd-current@freebsd.org [mailto:owner-freebsd- > current@freebsd.org] On Behalf Of Garrett Cooper > Sent: Sunday, May 13, 2012 5:49 PM > To: Outback Dingo > Cc: freebsd-current > Subject: Re: FYI FreeBSD clang build fails on new import of sort >=20 > On Sun, May 13, 2012 at 5:02 PM, Outback Dingo > wrote: > > trying to rerun a clang build of FreeBSD CURRENT fails on new import > of sort, > > > > cat /etc/src.conf > > WITH_CLANG_IS_CC=3D1 > > make world > > ---------------------SNIP--------------------------- > > clang -O2 -pipe =A0-DSORT_THREADS -std=3Dgnu99 -Qunused-arguments > > -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W > > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes > > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch > > -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline > > -Wnested-externs -Wredundant-decls -Wold-style-definition > > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c > > /usr/src/usr.bin/sort/coll.c > > clang -O2 -pipe =A0-DSORT_THREADS -std=3Dgnu99 -Qunused-arguments > > -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W > > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes > > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch > > -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline > > -Wnested-externs -Wredundant-decls -Wold-style-definition > > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c > > /usr/src/usr.bin/sort/file.c > > /usr/src/usr.bin/sort/file.c:601:12: error: format string is not a > > string literal (potentially insecure) [-Werror,-Wformat-security] > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, g= etstr(7)); > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ^~~~~~~~~ > > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro > 'getstr' > > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~ > > /usr/src/usr.bin/sort/file.c:942:11: error: format string is not a > > string literal (potentially insecure) [-Werror,-Wformat-security] > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, getstr(8)); > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~ > > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro > 'getstr' > > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~ > > /usr/src/usr.bin/sort/file.c:1279:10: error: format string is not a > > string literal (potentially insecure) [-Werror,-Wformat-security] > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, getstr(9)); > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~ > > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro > 'getstr' > > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~ > > /usr/src/usr.bin/sort/file.c:1295:12: error: format string is not a > > string literal (potentially insecure) [-Werror,-Wformat-security] > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0errx(2, getstr(10)); > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^~~~~~~~= ~~ > > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro > 'getstr' > > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~ > > 4 errors generated. > > *** [file.o] Error code 1 > > > > Stop in /usr/src/usr.bin/sort. >=20 > Yeah... errx(2, getstr(9)) should be errx(2, "%s", getstr(9))... > -Garrett > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current- > unsubscribe@freebsd.org"