From owner-freebsd-sysinstall@FreeBSD.ORG Mon Nov 1 16:10:13 2010 Return-Path: Delivered-To: freebsd-sysinstall@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 126B8106564A for ; Mon, 1 Nov 2010 16:10:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F41248FC12 for ; Mon, 1 Nov 2010 16:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA1GACng034547 for ; Mon, 1 Nov 2010 16:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA1GAC77034546; Mon, 1 Nov 2010 16:10:12 GMT (envelope-from gnats) Date: Mon, 1 Nov 2010 16:10:12 GMT Message-Id: <201011011610.oA1GAC77034546@freefall.freebsd.org> To: freebsd-sysinstall@FreeBSD.org From: Devin Teske Cc: Subject: Re: bin/113979: [patch] sysinstall(8) does not support UFS1 filesystems in install.cfg X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Devin Teske List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2010 16:10:13 -0000 The following reply was made to PR bin/113979; it has been noted by GNATS. From: Devin Teske To: bug-followup@FreeBSD.org, dsanderson@panasas.com Cc: Subject: Re: bin/113979: [patch] sysinstall(8) does not support UFS1 filesystems in install.cfg Date: Mon, 01 Nov 2010 08:37:21 -0700 Here's a cleaner patch (2-lines versus 4), reusing as much of what's already available in sysinstall. --- usr.sbin/sysinstall/label.c.orig 2010-02-19 12:26:30.000000000 -0800 +++ usr.sbin/sysinstall/label.c 2010-08-03 14:24:43.000000000 -0700 @@ -1647,6 +1647,8 @@ diskLabelNonInteractive(Device *dev) pi = tmp->private_data = new_part(PART_FILESYSTEM, mpoint, TRUE); tmp->private_free = safe_free; pi->newfs_data.newfs_ufs.softupdates = soft; + if (!strcmp(typ, "ufs1")) + pi->newfs_data.newfs_ufs.ufs1 = true; } } } -- Cheers, Devin Teske -> CONTACT INFORMATION <- Business Solutions Consultant II FIS - fisglobal.com 510-735-5650 Mobile 510-621-2038 Office 510-621-2020 Office Fax 909-477-4578 Home/Fax devin.teske@fisglobal.com -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> FUN STUFF <- -----BEGIN GEEK CODE BLOCK----- Version 3.1 GAT/CS d(+) s: a- C++(++++) UB++++$ P++(++++) L++(++++) !E--- W++ N? o? K- w O M+ V- PS+ PE Y+ PGP- t(+) 5? X+(++) R>++ tv(+) b+(++) DI+(++) D(+) G+>++ e>+ h r>++ y+ ------END GEEK CODE BLOCK------ http://www.geekcode.com/ -> END TRANSMISSION <-