From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Apr 1 19:50:03 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD2E31065677 for ; Tue, 1 Apr 2008 19:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 645FF8FC27 for ; Tue, 1 Apr 2008 19:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m31Jo3Ok042124 for ; Tue, 1 Apr 2008 19:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m31Jo3rT042123; Tue, 1 Apr 2008 19:50:03 GMT (envelope-from gnats) Resent-Date: Tue, 1 Apr 2008 19:50:03 GMT Resent-Message-Id: <200804011950.m31Jo3rT042123@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Frank Fenor Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4215A106564A for ; Tue, 1 Apr 2008 19:48:33 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 318258FC18 for ; Tue, 1 Apr 2008 19:48:33 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m31JmUkA044212 for ; Tue, 1 Apr 2008 19:48:30 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m31JmUYw044211; Tue, 1 Apr 2008 19:48:30 GMT (envelope-from nobody) Message-Id: <200804011948.m31JmUYw044211@www.freebsd.org> Date: Tue, 1 Apr 2008 19:48:30 GMT From: Frank Fenor To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/122354: Make irc/eggdrop compile with Tcl versions other than 8.4 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2008 19:50:03 -0000 >Number: 122354 >Category: ports >Synopsis: Make irc/eggdrop compile with Tcl versions other than 8.4 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Apr 01 19:50:03 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Frank Fenor >Release: FreeBSD 7.0-PRERELEASE >Organization: >Environment: FreeBSD konzentrisch.de 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #5: Tue Feb 5 00:33:58 CET 2008 >Description: Currently irc/eggdrop requires Tcl 8.4 which is wrong because eggdrop works just as good with other Tcl versions. If your system has (for example) Tcl 8.5 only, irc/eggdrop will install 8.4 instead of using 8.5. The attached patch changes the Makefile to use the bsd.tcl.mk functions to determine the newest installed Tcl version and point the eggdrop configure script to the appropriate files. I set the minimum required Tcl version to 8.0 (the smallest possible value) since the configure only requires 7.0. I also removed the manual setting of the build target because it results in exactly the same as compared to having the ports system automatically set it. I assume, it's better to use the provided value in case of future changes. If this was set on purpose to circumvent a problem in other environments, you should not include this change. >How-To-Repeat: pkg_delete tcl84 cd /usr/ports/irc/eggdrop make clean && make >Fix: cd /usr/ports/irc/eggdrop && patch -p1 < patch.txt Patch attached with submission follows: diff -Nru eggdrop.vanilla/Makefile eggdrop/Makefile --- eggdrop.vanilla/Makefile 2007-06-15 11:37:12.000000000 +0200 +++ eggdrop/Makefile 2008-04-01 21:19:13.000000000 +0200 @@ -19,13 +19,12 @@ MAINTAINER= beech@FreeBSD.org COMMENT= The most popular open source Internet Relay Chat bot -LIB_DEPENDS= tcl84.1:${PORTSDIR}/lang/tcl84 +USE_TCL= 84+ USE_BZIP2= yes GNU_CONFIGURE= yes -CONFIGURE_TARGET= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL} -CONFIGURE_ARGS= --with-tcllib=${LOCALBASE}/lib/libtcl84.so \ - --with-tclinc=${LOCALBASE}/include/tcl8.4/tcl.h +CONFIGURE_ARGS= --with-tcllib=${LOCALBASE}/lib/libtcl${TCL_VER:S/.//}.so \ + --with-tclinc=${TCL_INCLUDEDIR}/tcl.h OPTIONS= SSL "Use SSL" off >Release-Note: >Audit-Trail: >Unformatted: