From owner-freebsd-current Sat Apr 27 16: 8:34 2002 Delivered-To: freebsd-current@freebsd.org Received: from fw.wemm.org (12-232-135-171.client.attbi.com [12.232.135.171]) by hub.freebsd.org (Postfix) with ESMTP id ABF2F37B421; Sat, 27 Apr 2002 16:08:29 -0700 (PDT) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (8.11.6/8.11.6) with ESMTP id g3RN8Te50515; Sat, 27 Apr 2002 16:08:29 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 970ED38FD; Sat, 27 Apr 2002 16:08:29 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Maxime Henrion Cc: current@FreeBSD.ORG Subject: Re: Recent commit to sys/kern/kern_environment.c broke reading tunables In-Reply-To: <20020427205753.1F69938FD@overcee.wemm.org> Date: Sat, 27 Apr 2002 16:08:29 -0700 From: Peter Wemm Message-Id: <20020427230829.970ED38FD@overcee.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Peter Wemm wrote: > Maxime Henrion wrote: > > Hi, > > > > > > I think I may have found the bug. Could someone test the attached patch > > and report if it fixes the problem or not ? > > > > Thanks in advance, > > Maxime > > No joy: > > FreeBSD 5.0-CURRENT #8: Sat Apr 27 13:48:13 PDT 2002 > peter@ashburton.netplex.com.au:/home/src/sys/alpha/compile/ASHBURTON > Preloaded elf kernel "/boot/kernel/kernel" at 0xfffffc00005f6000. > EB164 > Digital AlphaPC 164SX 533 MHz, 531MHz > 8192 byte page size, 1 processor. > CPU: PCA56 (21164PC) major=9 minor=2 extensions=0x101 > OSF PAL rev: 0x1000600020117 > real memory = 132038656 (128944K bytes) > > > Sorry.. :-/ (I'll look at this today) This turned out to be part of the problem. I committed your patch and another followup that got the rest of it. The outstanding problems were: 1) checkmethod caused use_kenv to be set only once and the next time it was called, use_kenv would stay at zero and static hints only got used. 2) the termination of the kenvp[] loop could do a null deref. Anyway, I've committed both your and my changes, it should be working now. If anybody else sees problems still, please yell. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message