From nobody Thu Sep 4 16:33:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cHlRV1ptWz66Nrd; Thu, 04 Sep 2025 16:33:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cHlRV00Tqz42ms; Thu, 04 Sep 2025 16:33:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757003638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u+7MnDG6+z5iiynFPRvEDOofHzBbEMNXpEyEmJfVY8U=; b=e48EUff9NKl8/trVP36a91hQjFc3NX+WRm2zAr6XLyvUMOBwHPUMfHgACwJ6S0uIbIydGA sXs9bjyhFHt/gynDdY+IriDNWW+w4TlmwS8/oMJnwUDe1VJ9IWtKfTgZ/4npDs7QDHCgI4 npLXV8J++hFjcyIKpOAKzAfEE6HBSPhra+sQZXJdHM6rMro/q2CKjDM8E5IXpE9qkyZf2j 0AMBtiy15T200AWEGMKaoBO0Lm2tIBYVu9zp+aAKsudRM5CCk0fwQlEXHBOo4iobNbRQyF +ebm+FvoVFZou0bu7QaDi/f5nNmdHlwDShhLep5Pshvdo989FXcCfw/rtxj6Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757003638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u+7MnDG6+z5iiynFPRvEDOofHzBbEMNXpEyEmJfVY8U=; b=kLFKCW5l/NfLDBLygS2plF+dqFnuDmc77ilnr/lBwUG2SOIIl9bUf7uKhQsyVGVQ1disg/ vUIxwgamlr3zZYLSxWjF1rVzQD/Tx2cd3IOpeNl3lc1aPoBoBCJ8W43RvhXRPbs5RHBMmM 5shz9sjPr01IJWuFfb/sVkSHLTkkeDQB7O2wmW2v+z1stsZWmCl/S4h5WZDfmZ4PaqLT9W jRXVw5n+JJkv7uw6ARkm4QOTwS2S+KHH+BKYitRdU1Yc7iIJstRcDsrppm4mrRdp0RFMm4 D0CRl8dGl13gTUMnAjZg9h4mWI02DOX2keq8tZ3eSl3JmRjNy0EHVrXCRFoW1A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757003638; a=rsa-sha256; cv=none; b=c6TsxAkGwGDRaM3izfE8UJUHiZaF81GUFzp6tqXxrKMvY3+jG/4RBRHsrQynK8OlKWntJX uuCHryKccXWA58q6P3RgixwCICfYgBix/qH2kkKfDtd0gychIYMt01a+q0yCCqIUnbrgHu qoV5HUnxEoQ8Qhex5kdy/gHfYBIqdl+/13xLgU2tVA24SJqBupp4OCIe5wZQ2Vk7k5dpx3 /DarYYKZBY5Ax6yE8Za4KSc0PL5zPRIPEUdnmNuHChg+5SMGJQCaOattTCjIT3CQmWmKGP FVHU5kggnH2P3IS05KpWD4I1YG91g1LNNBshvTIvdLqXflddMN9PvorUIKFnjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cHlRT6djFz18m1; Thu, 04 Sep 2025 16:33:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 584GXvfV049759; Thu, 4 Sep 2025 16:33:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 584GXven049756; Thu, 4 Sep 2025 16:33:57 GMT (envelope-from git) Date: Thu, 4 Sep 2025 16:33:57 GMT Message-Id: <202509041633.584GXven049756@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lexi Winter Subject: git: 93a734f07a22 - main - bridge: Set member_ifaddrs=1 by default List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 93a734f07a22464952b35ad0888c6fdb6e099921 Auto-Submitted: auto-generated The branch main has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=93a734f07a22464952b35ad0888c6fdb6e099921 commit 93a734f07a22464952b35ad0888c6fdb6e099921 Author: Lexi Winter AuthorDate: 2025-09-04 16:23:18 +0000 Commit: Lexi Winter CommitDate: 2025-09-04 16:33:39 +0000 bridge: Set member_ifaddrs=1 by default We aren't ready to release with this set to 0: there's no solution for running DHCP on a bridge from a devd hook, there are missing edge cases like network boot with the boot interface in a bridge, and third-party tools (e.g., vm-bhyve) still direct users to use the incorrect configuration and/or don't support the correct configuration. Based on popular vote, we'll set this back to 0 in both main and for stable/15. MFC after: 9 hours Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D52336 --- sys/net/if_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c index 41847131c73d..cea7f1cb5e23 100644 --- a/sys/net/if_bridge.c +++ b/sys/net/if_bridge.c @@ -522,7 +522,7 @@ SYSCTL_BOOL(_net_link_bridge, OID_AUTO, log_mac_flap, "Log MAC address port flapping"); /* allow IP addresses on bridge members */ -VNET_DEFINE_STATIC(bool, member_ifaddrs) = false; +VNET_DEFINE_STATIC(bool, member_ifaddrs) = true; #define V_member_ifaddrs VNET(member_ifaddrs) SYSCTL_BOOL(_net_link_bridge, OID_AUTO, member_ifaddrs, CTLFLAG_RW | CTLFLAG_VNET, &VNET_NAME(member_ifaddrs), false,