From owner-freebsd-acpi@FreeBSD.ORG  Sun Feb 13 20:04:20 2005
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4B5FE16A4CE
	for <freebsd-acpi@freebsd.org>; Sun, 13 Feb 2005 20:04:20 +0000 (GMT)
Received: from ylpvm15.prodigy.net (ylpvm15-ext.prodigy.net [207.115.57.46])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E74FE43D54
	for <freebsd-acpi@freebsd.org>; Sun, 13 Feb 2005 20:04:19 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.0.115] (adsl-64-171-186-189.dsl.snfc21.pacbell.net
	[64.171.186.189])j1DK05bs005959;	Sun, 13 Feb 2005 15:00:05 -0500
Message-ID: <420FB25B.8010106@root.org>
Date: Sun, 13 Feb 2005 12:02:35 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041205)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "Alexandre \"Sunny\" Kovalenko" <Alex.Kovalenko@verizon.net>
References: <1107914318.1015.15.camel@RabbitsDen>
In-Reply-To: <1107914318.1015.15.camel@RabbitsDen>
Content-Type: text/plain; charset=ISO-8859-5; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-acpi@freebsd.org
Subject: Re: Thermal state switching
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Feb 2005 20:04:20 -0000

Alexandre "Sunny" Kovalenko wrote:
> Good people,
> 
> I was looking at thermal states switching by acpi_thermal.c and it looks
> like follows (provided that temperature raises and falls slowly and
> gradually):
> 
> NONE =up> AC2 =up> AC1 =up> AC0 =down> NONE                       (1)
> 
> I do not know whether this was intentional or not and, for me, something
> along the lines of
> 
> NONE =up> AC2 =up> AC1 =up> AC0 =down> AC1 =down> AC2 =down> NONE (2)
> 
> seemed more natural.
> 
> If (2) and not (1) was indeed the desired behavior attached patch seems
> to do the job. If (1) is what was intended, I do apologize for the
> noise.
> 
> I am running -CURRENT from February 3.

The behavior should be as in #2.  If it isn't, we should fix that. 
However, I'm not sure how your patch would fix this.  It seems more 
correct in that we only set the starting time after switching coolers 
but I don't see how this affects the ACx levels.  Could you explain more?

Thanks,
-- 
Nate