Date: Sun, 05 Jan 2025 18:54:50 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 942e8b555262 - main - graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files Message-ID: <ff56f0441a00205cb6405e827c3f7467@mail.infomaniak.com> In-Reply-To: <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com> References: <202501051538.505FcMKp033044@gitrepo.freebsd.org> <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1736099690_a2f859466f1df5ae8e661d0db1054e55_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2025-01-05T18:47:02.000+01:00, Daniel Engberg <daniel.engberg.lists@py= ret.net> wrote: >=C2=A0On=C2=A02025-01-05T16:38:28.000+01:00,=C2=A0Dir= k=C2=A0Meyer=C2=A0<dinoex@FreeBSD.org> >=C2=A0 >=C2=A0wrote: >=C2= =A0 >>=C2=A0=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updat= ed=C2=A0by=C2=A0dinoex: >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0URL: >>= =C2=A0=C2=A0https://cgit.FreeBSD.org/ports/commit/?id=3D942e8b555262a6e684e= f69e96e0036e065fb8211 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0commit=C2= =A0942e8b555262a6e684ef69e96e0036e065fb8211 >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0Author:=C2=A0Dirk=C2=A0Meyer=C2=A0<dinoex@FreeBSD.org> >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0AuthorDate:=C2=A02025-01-05=C2=A015:38:1= 1=C2=A0+0000 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Commit:=C2=A0Dirk=C2= =A0Meyer=C2=A0<dinoex@FreeBSD.org> >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2= =A0CommitDate:=C2=A02025-01-05=C2=A015:38:11=C2=A0+0000 >>=C2=A0=C2=A0 = >>=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg:=C2=A0Converts=C2=A0PCD=C2=A0(Kodak= =C2=A0Photo=C2=A0CD)=C2=A0image=C2=A0files >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0--- >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0graphics/Makefile= =C2=A0|=C2=A01=C2=A0+ >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0graphics/pcdto= jpeg/Makefile=C2=A0|=C2=A033=C2=A0++++++ >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0=C2=A0graphics/pcdtojpeg/distinfo=C2=A0|=C2=A03=C2=A0+ >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg/pkg-descr=C2=A0|=C2=A03=C2= =A0+ >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0graphics/pcdtojpeg/pkg-plist= =C2=A0|=C2=A0238 >>=C2=A0=C2=A0++++++++++++++++++++++++++++++++++++++++++= + >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A05=C2=A0files=C2=A0changed,=C2= =A0278=C2=A0insertions(+) >=C2=A0 >=C2=A0Hi, >=C2=A0 >=C2=A0Unfortu= nately=C2=A0this=C2=A0appears=C2=A0to=C2=A0be=C2=A0broken=C2=A0in=C2=A0mult= iple=C2=A0ways. >=C2=A0 >=C2=A0Resulting=C2=A0binary=C2=A0doesn't=C2= =A0work=C2=A0(14.2-RELEASE=C2=A0on=C2=A0amd64): >=C2=A0 >=C2=A0pcdtojpe= g=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcd-stock.jpeg >=C2=A0 >=C2=A0Segme= ntation=C2=A0fault=C2=A0(core=C2=A0dumped) >=C2=A0 >=C2=A0pcdtojpeg= =C2=A0-r=C2=A04=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcdtojpeg-5.jpg >=C2= =A0 >=C2=A0Segmentation=C2=A0fault=C2=A0(core=C2=A0dumped) >=C2=A0 >= =C2=A0pcdtojpeg=C2=A0-r=C2=A03=C2=A0BlownJohn.pcd=C2=A0BlownJohn-pcdtojpeg-= 5.jpg >=C2=A0 >=C2=A0Segmentation=C2=A0fault=C2=A0(core=C2=A0dumped) = >=C2=A0 >=C2=A0pcdtojpeg=C2=A0-r=C2=A05=C2=A0BlownJohn.pcd=C2=A0BlownJohn= -pcdtojpeg-5.jpg >=C2=A0 >=C2=A0Warning:=C2=A0Could=C2=A0not=C2=A0open= =C2=A064Base=C2=A0IPE=C2=A0file >=C2=A0 >=C2=A0while=C2=A0trying=C2= =A0to=C2=A0process=C2=A0ICE=C2=A0file >=C2=A0 >=C2=A0"/home/diizzy/patc= hes-upstream/IPE/BlownJohn/64BASE/INFO.IC" >=C2=A0 >=C2=A0Segmentation= =C2=A0fault=C2=A0(core=C2=A0dumped) >=C2=A0 >=C2=A0While=C2=A0documenta= tion=C2=A0is=C2=A0provided=C2=A0a=C2=A0note=C2=A0about=C2=A0this=C2=A0durin= g=C2=A0install >=C2=A0would >=C2=A0 >=C2=A0be=C2=A0helpful. >=C2= =A0 >=C2=A0Image=C2=A0source: >=C2=A0 >=C2=A0https://sembiance.com/fi= leFormatSamples/image/pcd/ >=C2=A0 >=C2=A0CXXFLAGS=C2=A0are=C2=A0droppe= d=C2=A0due=C2=A0to=C2=A0misspelling >=C2=A0 >=C2=A0https://cgit.freebsd= .org/ports/tree/graphics/pcdtojpeg/Makefile?id=3D942e8b555262a6e684ef69e96e= 0036e065fb8211#n23 >=C2=A0 >=C2=A0We=C2=A0likely=C2=A0avoid=C2=A0doing= =C2=A0exercises=C2=A0with=C2=A0tar=C2=A0in=C2=A0post-install=C2=A0sections?= >=C2=A0 >=C2=A0Please=C2=A0sort=C2=A0USES=C2=A0and=C2=A0make=C2=A0it= =C2=A0a=C2=A0separate=C2=A0sections. >=C2=A0 >=C2=A0I'm=C2=A0not=C2= =A0sure=C2=A0if=C2=A0the=C2=A0claims=C2=A0on=C2=A0the=C2=A0page=C2=A0are= =C2=A0still=C2=A0valid=C2=A0as >=C2=A0ImageMagick7 >=C2=A0 >=C2=A0app= ears=C2=A0to=C2=A0work=C2=A0fine=C2=A0as=C2=A0long=C2=A0as=C2=A0you=C2= =A0set=C2=A0colorspace=C2=A0to=C2=A0sRGB=C2=A0during >=C2=A0 >=C2=A0con= version. >=C2=A0 >=C2=A0Best=C2=A0regards, >=C2=A0 >=C2=A0Daniel = Hi, Might also add that ffmpeg also seems to convert without any is= sues however the image is rotated 90 degrees. Best regards, Dan= iel --_=_swift_1736099690_a2f859466f1df5ae8e661d0db1054e55_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s= ans-serif;font-size:14px;">On 2025-01-05T18:47:02.000+01:00, Daniel Engberg= <<a href=3D"mailto:daniel.engberg.lists@pyret.net" class=3D"defaultMail= Link defaultMailLink">daniel.engberg.lists@pyret.net</a>> wrote:<br></di= v><div class=3D"ik_mail_quote answerContentMessage"><blockquote class=3D"ws= -ng-quote"><pre style=3D"white-space:normal;"><div>On 2025-01-05T16:38:28.0= 00+01:00, Dirk Meyer <<a href=3D"mailto:dinoex@FreeBSD.org" class=3D"def= aultMailLink defaultMailLink">dinoex@FreeBSD.org</a>><br></div><div>wrot= e:<br></div><div><br></div><blockquote class=3D"ws-ng-quote"><div> The bra= nch main has been updated by dinoex:<br></div><div> <br></div><div> URL: <a= data-ik=3D"ik-secure" rel=3D"noopener noreferrer" href=3D"https://cgit.Fre= eBSD.org/ports/commit/?id=3D942e8b555262a6e684ef69e96e0036e065fb8211" class= =3D"defaultMailLink defaultMailLink" target=3D"_blank">https://cgit.FreeBSD= .org/ports/commit/?id=3D942e8b555262a6e684ef69e96e0036e065fb8211</a><br></d= iv><div> <br></div><div> commit 942e8b555262a6e684ef69e96e0036e065fb8211<br= ></div><div> <br></div><div> Author: Dirk Meyer <<a href=3D"mailto:d= inoex@FreeBSD.org" class=3D"defaultMailLink defaultMailLink">dinoex@FreeBSD= .org</a>><br></div><div> <br></div><div> AuthorDate: 2025-01-05 15:38:11= +0000<br></div><div> <br></div><div> Commit: Dirk Meyer <<a href=3D= "mailto:dinoex@FreeBSD.org" class=3D"defaultMailLink defaultMailLink">dinoe= x@FreeBSD.org</a>><br></div><div> <br></div><div> CommitDate: 2025-01-05= 15:38:11 +0000<br></div><div> <br></div><div> graphics/pcdtojpeg: Conv= erts PCD (Kodak Photo CD) image files<br></div><div> <br></div><div> ---<br= ></div><div> <br></div><div> graphics/Makefile | 1 +<br></div= ><div> <br></div><div> graphics/pcdtojpeg/Makefile | 33 ++++++<br></div>= <div> <br></div><div> graphics/pcdtojpeg/distinfo | 3 +<br></div><div> = <br></div><div> graphics/pcdtojpeg/pkg-descr | 3 +<br></div><div> <br></= div><div> graphics/pcdtojpeg/pkg-plist | 238 +++++++++++++++++++++++++++++= ++++++++++++++<br></div><div> <br></div><div> 5 files changed, 278 inserti= ons(+)<br></div></blockquote><div> <br></div><div>Hi,<br></div><div><br></d= iv><div>Unfortunately this appears to be broken in multiple ways.<br></div>= <div><br></div><div>Resulting binary doesn't work (14.2-RELEASE on amd64):<= br></div><div><br></div><div>pcdtojpeg BlownJohn.pcd BlownJohn-pcd-stock.jp= eg<br></div><div><br></div><div>Segmentation fault (core dumped)<br></div><= div><br></div><div>pcdtojpeg -r 4 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<b= r></div><div><br></div><div>Segmentation fault (core dumped)<br></div><div>= <br></div><div>pcdtojpeg -r 3 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></= div><div><br></div><div>Segmentation fault (core dumped)<br></div><div><br>= </div><div>pcdtojpeg -r 5 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></div>= <div><br></div><div>Warning: Could not open 64Base IPE file<br></div><div><= br></div><div>while trying to process ICE file<br></div><div>"/home/diizzy/= patches-upstream/IPE/BlownJohn/64BASE/INFO.IC"<br></div><div><br></div><div= >Segmentation fault (core dumped)<br></div><div><br></div><div>While docume= ntation is provided a note about this during install would<br></div><div>be= helpful.<br></div><div><br></div><div>Image source:<br></div><div><br></di= v><div><a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" href=3D"https:/= /sembiance.com/fileFormatSamples/image/pcd/" class=3D"defaultMailLink defau= ltMailLink" target=3D"_blank">https://sembiance.com/fileFormatSamples/image= /pcd/</a><br></div><div><br></div><div>CXXFLAGS are dropped due to misspell= ing<br></div><div><br></div><div><a data-ik=3D"ik-secure" rel=3D"noopener n= oreferrer" href=3D"https://cgit.freebsd.org/ports/tree/graphics/pcdtojpeg/M= akefile?id=3D942e8b555262a6e684ef69e96e0036e065fb8211#n23" class=3D"default= MailLink defaultMailLink" target=3D"_blank">https://cgit.freebsd.org/ports/= tree/graphics/pcdtojpeg/Makefile?id=3D942e8b555262a6e684ef69e96e0036e065fb8= 211#n23</a><br></div><div><br></div><div>We likely avoid doing exercises wi= th tar in post-install sections?<br></div><div><br></div><div>Please sort U= SES and make it a separate sections.<br></div><div><br></div><div>I'm not s= ure if the claims on the page are still valid as ImageMagick7<br></div><div= >appears to work fine as long as you set colorspace to sRGB during<br></div= ><div>conversion.<br></div><div><br></div><div>Best regards,<br></div><div>= <br></div><div>Daniel<br></div></pre></blockquote></div><div style=3D"font-= family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Hi,<= br></div><div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, sans= -serif;font-size:14px;"><br></div><div style=3D"font-family:'Helvetica Neue= ', Helvetica, Arial, sans-serif;font-size:14px;">Might also add that ffmpeg= also seems to convert without any issues however the image is rotated 90 d= egrees.<br></div><div style=3D"font-family:'Helvetica Neue', Helvetica, Ari= al, sans-serif;font-size:14px;"><br></div><div style=3D"font-family:'Helvet= ica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Best regards,<br><= /div><div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, sans-ser= if;font-size:14px;">Daniel<br></div></body></html> --_=_swift_1736099690_a2f859466f1df5ae8e661d0db1054e55_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ff56f0441a00205cb6405e827c3f7467>