Date: Sun, 05 Jan 2025 18:54:50 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 942e8b555262 - main - graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files Message-ID: <ff56f0441a00205cb6405e827c3f7467@mail.infomaniak.com> In-Reply-To: <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com> References: <202501051538.505FcMKp033044@gitrepo.freebsd.org> <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2025-01-05T18:47:02.000+01:00, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote: > On 2025-01-05T16:38:28.000+01:00, Dirk Meyer <dinoex@FreeBSD.org> > > wrote: > >> The branch main has been updated by dinoex: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=942e8b555262a6e684ef69e96e0036e065fb8211 >> >> commit 942e8b555262a6e684ef69e96e0036e065fb8211 >> >> Author: Dirk Meyer <dinoex@FreeBSD.org> >> >> AuthorDate: 2025-01-05 15:38:11 +0000 >> >> Commit: Dirk Meyer <dinoex@FreeBSD.org> >> >> CommitDate: 2025-01-05 15:38:11 +0000 >> >> graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files >> >> --- >> >> graphics/Makefile | 1 + >> >> graphics/pcdtojpeg/Makefile | 33 ++++++ >> >> graphics/pcdtojpeg/distinfo | 3 + >> >> graphics/pcdtojpeg/pkg-descr | 3 + >> >> graphics/pcdtojpeg/pkg-plist | 238 >> +++++++++++++++++++++++++++++++++++++++++++ >> >> 5 files changed, 278 insertions(+) > > Hi, > > Unfortunately this appears to be broken in multiple ways. > > Resulting binary doesn't work (14.2-RELEASE on amd64): > > pcdtojpeg BlownJohn.pcd BlownJohn-pcd-stock.jpeg > > Segmentation fault (core dumped) > > pcdtojpeg -r 4 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg > > Segmentation fault (core dumped) > > pcdtojpeg -r 3 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg > > Segmentation fault (core dumped) > > pcdtojpeg -r 5 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg > > Warning: Could not open 64Base IPE file > > while trying to process ICE file > > "/home/diizzy/patches-upstream/IPE/BlownJohn/64BASE/INFO.IC" > > Segmentation fault (core dumped) > > While documentation is provided a note about this during install > would > > be helpful. > > Image source: > > https://sembiance.com/fileFormatSamples/image/pcd/ > > CXXFLAGS are dropped due to misspelling > > https://cgit.freebsd.org/ports/tree/graphics/pcdtojpeg/Makefile?id=942e8b555262a6e684ef69e96e0036e065fb8211#n23 > > We likely avoid doing exercises with tar in post-install sections? > > Please sort USES and make it a separate sections. > > I'm not sure if the claims on the page are still valid as > ImageMagick7 > > appears to work fine as long as you set colorspace to sRGB during > > conversion. > > Best regards, > > Daniel Hi, Might also add that ffmpeg also seems to convert without any issues however the image is rotated 90 degrees. Best regards, Daniel [-- Attachment #2 --] <html><body><div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">On 2025-01-05T18:47:02.000+01:00, Daniel Engberg <<a href="mailto:daniel.engberg.lists@pyret.net" class="defaultMailLink defaultMailLink">daniel.engberg.lists@pyret.net</a>> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space:normal;"><div>On 2025-01-05T16:38:28.000+01:00, Dirk Meyer <<a href="mailto:dinoex@FreeBSD.org" class="defaultMailLink defaultMailLink">dinoex@FreeBSD.org</a>><br></div><div>wrote:<br></div><div><br></div><blockquote class="ws-ng-quote"><div> The branch main has been updated by dinoex:<br></div><div> <br></div><div> URL: <a data-ik="ik-secure" rel="noopener noreferrer" href="https://cgit.FreeBSD.org/ports/commit/?id=942e8b555262a6e684ef69e96e0036e065fb8211" class="defaultMailLink defaultMailLink" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=942e8b555262a6e684ef69e96e0036e065fb8211</a><br></div><div>; <br></div><div> commit 942e8b555262a6e684ef69e96e0036e065fb8211<br></div><div> <br></div><div> Author: Dirk Meyer <<a href="mailto:dinoex@FreeBSD.org" class="defaultMailLink defaultMailLink">dinoex@FreeBSD.org</a>><br></div><div> <br></div><div> AuthorDate: 2025-01-05 15:38:11 +0000<br></div><div> <br></div><div> Commit: Dirk Meyer <<a href="mailto:dinoex@FreeBSD.org" class="defaultMailLink defaultMailLink">dinoex@FreeBSD.org</a>><br></div><div> <br></div><div> CommitDate: 2025-01-05 15:38:11 +0000<br></div><div> <br></div><div> graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files<br></div><div> <br></div><div> ---<br></div><div> <br></div><div> graphics/Makefile | 1 +<br></div><div> <br></div><div> graphics/pcdtojpeg/Makefile | 33 ++++++<br></div><div> <br></div><div> graphics/pcdtojpeg/distinfo | 3 +<br></div><div> <br></div><div> graphics/pcdtojpeg/pkg-descr | 3 +<br></div><div> <br></div><div> graphics/pcdtojpeg/pkg-plist | 238 +++++++++++++++++++++++++++++++++++++++++++<br></div><div> <br></div><div> 5 files changed, 278 insertions(+)<br></div></blockquote><div> <br></div><div>Hi,<br></div><div><br></div><div>Unfortunately this appears to be broken in multiple ways.<br></div><div><br></div><div>Resulting binary doesn't work (14.2-RELEASE on amd64):<br></div><div><br></div><div>pcdtojpeg BlownJohn.pcd BlownJohn-pcd-stock.jpeg<br></div><div><br></div><div>Segmentation fault (core dumped)<br></div><div><br></div><div>pcdtojpeg -r 4 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></div><div><br></div><div>Segmentation fault (core dumped)<br></div><div><br></div><div>pcdtojpeg -r 3 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></div><div><br></div><div>Segmentation fault (core dumped)<br></div><div><br></div><div>pcdtojpeg -r 5 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg<br></div><div><br></div><div>Warning: Could not open 64Base IPE file<br></div><div><br></div><div>while trying to process ICE file<br></div><div>"/home/diizzy/patches-upstream/IPE/BlownJohn/64BASE/INFO.IC"<br></div><div><br></div><div>Segmentation fault (core dumped)<br></div><div><br></div><div>While documentation is provided a note about this during install would<br></div><div>be helpful.<br></div><div><br></div><div>Image source:<br></div><div><br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" href="https://sembiance.com/fileFormatSamples/image/pcd/" class="defaultMailLink defaultMailLink" target="_blank">https://sembiance.com/fileFormatSamples/image/pcd/</a><br></div><div><br></div><div>CXXFLAGS are dropped due to misspelling<br></div><div><br></div><div><a data-ik="ik-secure" rel="noopener noreferrer" href="https://cgit.freebsd.org/ports/tree/graphics/pcdtojpeg/Makefile?id=942e8b555262a6e684ef69e96e0036e065fb8211#n23" class="defaultMailLink defaultMailLink" target="_blank">https://cgit.freebsd.org/ports/tree/graphics/pcdtojpeg/Makefile?id=942e8b555262a6e684ef69e96e0036e065fb8211#n23</a><br></div><div><br></div><div>We likely avoid doing exercises with tar in post-install sections?<br></div><div><br></div><div>Please sort USES and make it a separate sections.<br></div><div><br></div><div>I'm not sure if the claims on the page are still valid as ImageMagick7<br></div><div>appears to work fine as long as you set colorspace to sRGB during<br></div><div>conversion.<br></div><div><br></div><div>Best regards,<br></div><div><br></div><div>Daniel<br></div></pre></blockquote></div><div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Hi,<br></div><div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;"><br></div><div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Might also add that ffmpeg also seems to convert without any issues however the image is rotated 90 degrees.<br></div><div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;"><br></div><div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Best regards,<br></div><div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:14px;">Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ff56f0441a00205cb6405e827c3f7467>