From owner-svn-src-user@FreeBSD.ORG  Sat Apr 11 14:12:45 2009
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 31729106567F;
	Sat, 11 Apr 2009 14:12:45 +0000 (UTC)
	(envelope-from piso@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 1F6168FC0A;
	Sat, 11 Apr 2009 14:12:45 +0000 (UTC)
	(envelope-from piso@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3BECiN6088342;
	Sat, 11 Apr 2009 14:12:44 GMT (envelope-from piso@svn.freebsd.org)
Received: (from piso@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3BECiAA088341;
	Sat, 11 Apr 2009 14:12:44 GMT (envelope-from piso@svn.freebsd.org)
Message-Id: <200904111412.n3BECiAA088341@svn.freebsd.org>
From: Paolo Pisati <piso@FreeBSD.org>
Date: Sat, 11 Apr 2009 14:12:44 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r190921 - user/piso/ipfw/sys/netinet/libalias
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Apr 2009 14:12:45 -0000

Author: piso
Date: Sat Apr 11 14:12:44 2009
New Revision: 190921
URL: http://svn.freebsd.org/changeset/base/190921

Log:
  Correctly check return code after modules ran: this fix a bug introduced in rev 1.54.

Modified:
  user/piso/ipfw/sys/netinet/libalias/alias.c

Modified: user/piso/ipfw/sys/netinet/libalias/alias.c
==============================================================================
--- user/piso/ipfw/sys/netinet/libalias/alias.c	Sat Apr 11 14:10:42 2009	(r190920)
+++ user/piso/ipfw/sys/netinet/libalias/alias.c	Sat Apr 11 14:12:44 2009	(r190921)
@@ -742,7 +742,7 @@ UdpAliasIn(struct libalias *la, struct i
 		u_short alias_port;
 		u_short proxy_port;
 		int accumulate;
-		int r = 0, error;
+		int error;
 		struct alias_data ad = {
 			.lnk = lnk, 
 			.oaddr = &original_address, 
@@ -804,7 +804,7 @@ UdpAliasIn(struct libalias *la, struct i
 		/*
 		 * If we cannot figure out the packet, ignore it.
 		 */
-		if (r < 0)
+		if (error < 0)
 			return (PKT_ALIAS_IGNORED);
 		else
 			return (PKT_ALIAS_OK);