From owner-cvs-sys  Sat Dec 14 17:50:19 1996
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id RAA11780
          for cvs-sys-outgoing; Sat, 14 Dec 1996 17:50:19 -0800 (PST)
Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67])
          by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id RAA11763;
          Sat, 14 Dec 1996 17:50:09 -0800 (PST)
Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1])
          by spinner.DIALix.COM (8.8.4/8.8.4) with ESMTP id JAA18365;
          Sun, 15 Dec 1996 09:49:29 +0800 (WST)
Message-Id: <199612150149.JAA18365@spinner.DIALix.COM>
To: Nate Williams <nate@mt.sri.com>
cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-sys@freefall.freebsd.org
Subject: Re: cvs commit: src/sys/i386/boot/rawboot Makefile 
In-reply-to: Your message of "Sat, 14 Dec 1996 18:42:20 MST."
             <199612150142.SAA26642@rocky.mt.sri.com> 
Date: Sun, 15 Dec 1996 09:49:28 +0800
From: Peter Wemm <peter@spinner.DIALix.COM>
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Nate Williams wrote:
> Peter Wemm writes:
> > peter       96/12/14 17:25:55
> > 
> >   Modified:    sys/i386/boot/rawboot  Makefile
> >   Log:
> >   Add missing -I so that probe_keyboard.c can find <i386/isa/kbdio.h>. :-(
> >   (Why, oh why did this include file end up in isa/ rather than include/ ?)
> 
> Because it's supposed to be only used by isa drivers. ;)
> 
> Nate

.. and it wouldn't need to be used if the keyboard IO port definitions
were not ripped out of <machine/cons.h>.  The boot code needs to know the
port addresses.  Those should have stayed in cons.h, the prototypes in kbdio.h
are only useful to users of kbdio.c (probe_keyboard doesn't use kbdio.c).

Cheers,
-Peter