From owner-cvs-all Tue Apr 9 13:20:39 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id C36AF37B41D; Tue, 9 Apr 2002 13:19:53 -0700 (PDT) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g39KJqYm036688; Tue, 9 Apr 2002 13:19:52 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g39KIbur036665; Tue, 9 Apr 2002 13:18:37 -0700 (PDT) Date: Tue, 9 Apr 2002 13:18:37 -0700 From: "David O'Brien" To: Alfred Perlstein Cc: "M. Warner Losh" , jhb@FreeBSD.org, kris@obsecurity.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ioccom.h Message-ID: <20020409131837.D35868@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20020408210151.B18407@xor.obsecurity.org> <20020408.222429.22925353.imp@village.org> <20020409064242.GJ93885@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020409064242.GJ93885@elvis.mu.org>; from bright@mu.org on Mon, Apr 08, 2002 at 11:42:42PM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Apr 08, 2002 at 11:42:42PM -0700, Alfred Perlstein wrote: > > : No, I already said that I reverted the ()'s locally and it still failed to > > : compile. Yes, I was editing /usr/include/sys/ioccom.h and not > > : /sys/sys/ioccom.h. I also tried putting __P() back in, but it didn't build > > : then either. I'm wondering if the pollution in screen's osdef.h is new? ... > > The real problem is at osdef.h:81: > > extern int ioctl __P((int, int, char *)); > > > > Note the two problems with this: > > 1) int doesn't match unsgined long > > 2) char * doesn't match ... > > > > screen needs to be fixed. here's a real patch: ... > I don't have the emails offhand, but the screen people were pretty > quick to respond to a help message from me. Have you contacted them > about bringing in this fix? While fixing screen is a good thing to do. Nobody seems to be able to determine just WHICH commit broke building it. I think we should determine that before "fixing" it. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message