From owner-freebsd-doc@FreeBSD.ORG Fri Jan 7 14:46:48 2011 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87E0A1065679 for ; Fri, 7 Jan 2011 14:46:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4472F8FC12 for ; Fri, 7 Jan 2011 14:46:48 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 006BE46B0D; Fri, 7 Jan 2011 09:46:48 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EB5ED8A02B; Fri, 7 Jan 2011 09:46:46 -0500 (EST) From: John Baldwin To: freebsd-doc@freebsd.org, joris dedieu Date: Fri, 7 Jan 2011 08:11:48 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <201101071230.p07CU9Dd044913@freefall.freebsd.org> In-Reply-To: <201101071230.p07CU9Dd044913@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201101070811.48852.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 07 Jan 2011 09:46:47 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Subject: Re: docs/153654: [patch] incorrect include in sysctl.9 X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 14:46:48 -0000 On Friday, January 07, 2011 7:30:09 am joris dedieu wrote: > The following reply was made to PR docs/153654; it has been noted by GNATS. > > From: joris dedieu > To: John Baldwin > Cc: freebsd-doc@freebsd.org, freebsd-gnats-submit@freebsd.org > Subject: Re: docs/153654: [patch] incorrect include in sysctl.9 > Date: Fri, 7 Jan 2011 12:58:21 +0100 > > 2011/1/3 John Baldwin : > > On Monday, January 03, 2011 12:58:53 pm Joris Dedieu wrote: > >> > >> >Number: =A0 =A0 =A0 =A0 153654 > >> >Category: =A0 =A0 =A0 docs > >> >Synopsis: =A0 =A0 =A0 [patch] incorrect include in sysctl.9 > >> >Confidential: =A0 no > >> >Severity: =A0 =A0 =A0 non-critical > >> >Priority: =A0 =A0 =A0 low > >> >Responsible: =A0 =A0freebsd-doc > >> >State: =A0 =A0 =A0 =A0 =A0open > >> >Quarter: > >> >Keywords: > >> >Date-Required: > >> >Class: =A0 =A0 =A0 =A0 =A0doc-bug > >> >Submitter-Id: =A0 current-users > >> >Arrival-Date: =A0 Mon Jan 03 18:00:24 UTC 2011 > >> >Closed-Date: > >> >Last-Modified: > >> >Originator: =A0 =A0 Joris Dedieu > >> >Release: =A0 =A0 =A0 =A08.1-RELEASE-p2 > >> >Organization: > >> >Environment: > >> FreeBSD ladybug2.rmdir.fr 8.1-RELEASE-p2 FreeBSD 8.1-RELEASE-p2 #0: Mon = > Dec 27 15:39:23 CET 2010 > > joris@ladybug2.rmdir.fr:/usr/obj/usr/src/sys/GENERIC =A0amd64 > >> > >> >Description: > >> Has DATA_SET is defined in sys/kernel.h most SYSTL_* macros don't work i= > f you don't include it. > >> >How-To-Repeat: > >> > >> >Fix: > >> --- share/man/man9/sysctl.9.orig =A0 =A0 =A0 =A02011-01-03 18:43:53.0000= > 00000 +0100 > >> +++ share/man/man9/sysctl.9 =A0 =A0 2011-01-03 18:44:17.000000000 +0100 > >> @@ -44,7 +44,7 @@ > >> =A0.Nm SYSCTL_QUAD > >> =A0.Nd Static sysctl declaration functions > >> =A0.Sh SYNOPSIS > >> -.In sys/types.h > >> +.In sys/kernel.h > >> =A0.In sys/sysctl.h > >> =A0.Fn SYSCTL_DECL name > >> =A0.Fn SYSCTL_INT parent nbr name access ptr val descr > > > > does not include . =A0Plus, all of l.h> > > is not needed. =A0 is what defines DATA_SET(). =A0This = > is > > probably the "right" set of includes: > > > > #include > > #include > > #include > > > > OTOH, should perhaps have a nested include of h> > > in the #ifdef _KERNEL case in which case the manpage would not need chang= > ing. > You are right. My patch is wrong and your solution sounds better. > Should I submit an other pr ? No, the existing PR is fine. I will ask bde@ which solution he prefers and then fix either the manpage or the header. Thanks! -- John Baldwin