From owner-p4-projects@FreeBSD.ORG  Mon Feb 25 23:18:09 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2FAD116A411; Mon, 25 Feb 2008 23:18:09 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DE51F16A40F
	for <perforce@freebsd.org>; Mon, 25 Feb 2008 23:18:08 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id D18F613C474
	for <perforce@freebsd.org>; Mon, 25 Feb 2008 23:18:08 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m1PNI8DW059048
	for <perforce@freebsd.org>; Mon, 25 Feb 2008 23:18:08 GMT
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m1PNI8f4059045
	for perforce@freebsd.org; Mon, 25 Feb 2008 23:18:08 GMT
	(envelope-from sam@freebsd.org)
Date: Mon, 25 Feb 2008 23:18:08 GMT
Message-Id: <200802252318.m1PNI8f4059045@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 136193 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2008 23:18:09 -0000

http://perforce.freebsd.org/chv.cgi?CH=136193

Change 136193 by sam@sam_ebb on 2008/02/25 23:17:59

	drop lock around call to ioctl handler to bring the
	parent interface up; this causes troubles for drivers
	that download firmware in their init method; in theor
	firmware should be downloaded on vap create but there
	may be other reasons to remove this restriction

Affected files ...

.. //depot/projects/vap/sys/net80211/ieee80211_proto.c#22 edit

Differences ...

==== //depot/projects/vap/sys/net80211/ieee80211_proto.c#22 (text+ko) ====

@@ -1099,8 +1099,10 @@
 			    IEEE80211_MSG_STATE | IEEE80211_MSG_DEBUG,
 			    "%s: up parent %s\n", __func__, parent->if_xname);
 			parent->if_flags |= IFF_UP;
-			/* XXX holding lock */
+			/* XXX drop lock */
+			IEEE80211_UNLOCK(ic);
 			parent->if_ioctl(parent, SIOCSIFFLAGS, NULL);
+			IEEE80211_LOCK(ic);
 		}
 		/*
 		 * Mark us running.  Note that we do this after