From owner-svn-src-head@freebsd.org Thu Dec 1 17:33:24 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE947C60BC2; Thu, 1 Dec 2016 17:33:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AD4761E53; Thu, 1 Dec 2016 17:33:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id c4so12241660pfb.3; Thu, 01 Dec 2016 09:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=b+UZPQpj8mbJg7yr9rF7WSN5dE46SDA/LHYekYT5lq0=; b=XFO5pPtP4Q+R3915250PXmmZrhoaoRxSBwssyMGujaSONiZtia6XmD/O20t6PGUDsz KSoSBPr0sFdt4umWrn2M5HfYz3JWCuNfkEq71/ZhjUBwmtogagNsSxAR7AolxBXo2vyA hXlcZIq49fZSEpIlUGnrHkiUO3gA9cuAk+14E7KHGaCqtChVtjw7jGGA+iWna7p47hfC bLQy4pgOExU0hNTHFvPy3fdI9eyQLxIL1IWehpb2FsI1VSgMPaJe6d8y3+t/yOJCBZry Omioe0vPW0O/COej/jLOWWAUQQqeUNrBTxILeJ+OUT2+02gPeeKqEW3HFS+bdg/VfXyq l7Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=b+UZPQpj8mbJg7yr9rF7WSN5dE46SDA/LHYekYT5lq0=; b=BrrnPrQ8k2DNznkFHmo2dQ0zBc4AeMxMS0mMLf07XrMUVHhSUmk4bJHuzN7NqXHuIn vreAn4ISk240nnPviVaEn1hs91tWp1jctrbaTySCBREMGwWy/VSsjP7XN14tCLxD6W4D ZEo/liTai9N1uPXjdJDX9rXLyn+jnTMJMleVWqDMoP4ZCTlWGC+/PE7B/6z8Ju9ulfWr y1jTTocS3LepN0qoOhMEN+PjMv3Jf4+4naKVtAibYyzepbEozNXnp7l1Qn8NQdjhPivN Cusw8OB76p4LFlEST+VLB+N/XoFtN8Wp0+BHTGB5MlCmIcwgNMpKOTIU28ZRoZF4e3RW 0JJA== X-Gm-Message-State: AKaTC03k7GSdaklxACiSe6Lb3iQB7rT2153HG0ASWLAuoL01KQgYKmSaVYpIa6tWWxwusw== X-Received: by 10.99.237.69 with SMTP id m5mr71056363pgk.94.1480613604320; Thu, 01 Dec 2016 09:33:24 -0800 (PST) Received: from fuji-wireless.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id q26sm1533523pfk.94.2016.12.01.09.33.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2016 09:33:23 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: svn commit: r309344 - head/lib/libutil From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20161201170116.GA20872@lonesome.com> Date: Thu, 1 Dec 2016 09:33:22 -0800 Cc: Ian Lepore , "Conrad E. Meyer" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <5B2D372D-52AB-42FB-B0AA-942A75466602@gmail.com> References: <201612010221.uB12Lb6x067202@repo.freebsd.org> <4DFE017D-90FD-44F4-8FE7-7EE53D499F7B@gmail.com> <1480609927.1889.189.camel@freebsd.org> <20161201170116.GA20872@lonesome.com> To: Mark Linimon X-Mailer: Apple Mail (2.3251) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 17:33:25 -0000 > On Dec 1, 2016, at 9:01 AM, Mark Linimon wrote: >=20 > On Thu, Dec 01, 2016 at 09:32:07AM -0700, Ian Lepore wrote: >> On Wed, 2016-11-30 at 19:07 -0800, Ngie Cooper wrote: >>> Really?? I wish you hadn't added me to this list.. I don't in any = way >>> endorse the way that you went about dealing with this disagreement. >>=20 >> Really? Well then feel free to ADD my name to the list of people who >> found that comment, and the subsequent non-response to the complaints >> about it, completely inappropriate. =20 >=20 > I expressed an opinion on an IRC channel that I found the comment > offensive. >=20 > But I would rather my permission had been asked ahead of time before > having that comment attached to a public commit log. I think this is > part of the point that ngie is trying to make. >=20 > I'm well-known for my wish that core took a more active, public, = stance > on such matters, but I think here that two wrongs may not have made a > right. Yes. And more importantly, the new comment doesn=E2=80=99t tell me *why* I = shouldn=E2=80=99t use FD_CLOEXEC. The owness is still on the reader to = figure out why using `fcntl(fd, F_SETFD, FD_CLOEXEC)` is wrong. All the new commit does is makes the commit that des@ made more = palatable and benign to readers. Thanks, -Ngie=