Date: Fri, 22 Jun 2012 19:44:28 +0200 From: Olli Hauer <ohauer@FreeBSD.org> To: FreeBSD Ports <ports@FreeBSD.org> Cc: Michael Scheidell <scheidell@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>, Ganael LAPLANCHE <martymac@FreeBSD.org>, Matthew Seaman <matthew@FreeBSD.org> Subject: Re: optionsng and tinderbox? Message-ID: <4FE4AEFC.4070405@FreeBSD.org> In-Reply-To: <20120621090226.M48537@FreeBSD.org> References: <4FE12F2D.9080302@FreeBSD.org> <20120620061136.GA79164@ithaqua.etoilebsd.net> <4FE1829D.6030109@FreeBSD.org> <20120620091321.GA83730@ithaqua.etoilebsd.net> <20120620094431.M12775@martymac.org> <20120620103412.GB83730@ithaqua.etoilebsd.net> <4FE1C1EA.8070901@FreeBSD.org> <20120621090226.M48537@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-06-21 11:26, Ganael LAPLANCHE wrote: > On Wed, 20 Jun 2012 13:28:26 +0100, Matthew Seaman wrote > > Hi Matthew, Baptiste, > > Thank you very much for your answers. > > With your patch, Matthew, setting : > > openldap24-client_SET+=FETCH > > in make.conf now works for net/openldap24-client : > > $ cd /usr/ports/net/openldap24-client > $ make -V PORT_OPTIONS > DOCS EXAMPLES FETCH NLS > > Great :) > >> [...] >> Shouldn't make.conf / commandline settings override OPTIONSFILE rather >> than the other way round? Seems there's not much point in being able to >> set options from make.conf unless that is so, as OPTIONSFILE would be >> created more often than not whenever make(1) was invoked in the port's >> directory. > > I think that command-line options should always override file ones, but > the main problem here is that we cannot distinguish what comes from the > command line from what comes from make.conf. > > What would sound logical to me would be the following order of precedence : > > make.conf -> overridden by option files -> overridden by command line This looks wrong to me. Options set in make.conf should not be overwritten by the option file else you don't need etc/make.conf at all. Given a port has as default set option A to on and you don't want option A then you cannot overwrite the default settings in make.conf with the suggested order. For example globally unset mysql and choose pgsql instead. -- olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FE4AEFC.4070405>