From owner-freebsd-ports@FreeBSD.ORG  Fri Jun 22 17:44:42 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E66E01065723;
	Fri, 22 Jun 2012 17:44:42 +0000 (UTC)
	(envelope-from ohauer@FreeBSD.org)
Received: from p578be941.dip0.t-ipconnect.de (p578be941.dip0.t-ipconnect.de
	[87.139.233.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 9B3D28FC1C;
	Fri, 22 Jun 2012 17:44:42 +0000 (UTC)
Received: from [192.168.0.100] (cde1100.uni.vrs [192.168.0.100])
	(Authenticated sender: ohauer)
	by p578be941.dip0.t-ipconnect.de (Postfix) with ESMTPSA id 9431320880; 
	Fri, 22 Jun 2012 19:44:31 +0200 (CEST)
Message-ID: <4FE4AEFC.4070405@FreeBSD.org>
Date: Fri, 22 Jun 2012 19:44:28 +0200
From: Olli Hauer <ohauer@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
	rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: FreeBSD Ports <ports@FreeBSD.org>
References: <4FE12F2D.9080302@FreeBSD.org>
	<20120620061136.GA79164@ithaqua.etoilebsd.net>
	<4FE1829D.6030109@FreeBSD.org>
	<20120620091321.GA83730@ithaqua.etoilebsd.net>
	<20120620094431.M12775@martymac.org>
	<20120620103412.GB83730@ithaqua.etoilebsd.net>
	<4FE1C1EA.8070901@FreeBSD.org> <20120621090226.M48537@FreeBSD.org>
In-Reply-To: <20120621090226.M48537@FreeBSD.org>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: Michael Scheidell <scheidell@FreeBSD.org>,
	Baptiste Daroussin <bapt@FreeBSD.org>,
	Ganael LAPLANCHE <martymac@FreeBSD.org>,
	Matthew Seaman <matthew@FreeBSD.org>
Subject: Re: optionsng and tinderbox?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: FreeBSD Ports <ports@FreeBSD.org>
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2012 17:44:43 -0000

On 2012-06-21 11:26, Ganael LAPLANCHE wrote:
> On Wed, 20 Jun 2012 13:28:26 +0100, Matthew Seaman wrote
> 
> Hi Matthew, Baptiste,
> 
> Thank you very much for your answers.
> 
> With your patch, Matthew, setting :
> 
> openldap24-client_SET+=FETCH
> 
> in make.conf now works for net/openldap24-client :
> 
> $ cd /usr/ports/net/openldap24-client
> $ make -V PORT_OPTIONS
> DOCS EXAMPLES FETCH NLS
> 
> Great :)
> 
>> [...]
>> Shouldn't make.conf / commandline settings override OPTIONSFILE rather
>> than the other way round?  Seems there's not much point in being able to
>> set options from make.conf unless that is so, as OPTIONSFILE would be
>> created more often than not whenever make(1) was invoked in the port's
>> directory.
> 
> I think that command-line options should always override file ones, but
> the main problem here is that we cannot distinguish what comes from the
> command line from what comes from make.conf.
> 
> What would sound logical to me would be the following order of precedence :
> 
> make.conf -> overridden by option files -> overridden by command line


This looks wrong to me.

Options set in make.conf should not be overwritten by the option file
else you don't need etc/make.conf at all.

Given a port has as default set option A to on and you don't want
option A then you cannot overwrite the default settings in make.conf
with the suggested order.

For example globally unset mysql and choose pgsql instead.

--
olli