From owner-cvs-sys Fri Sep 6 10:12:47 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id KAA13851 for cvs-sys-outgoing; Fri, 6 Sep 1996 10:12:47 -0700 (PDT) Received: from FileServ1.MI.Uni-Koeln.DE (FileServ1.MI.Uni-Koeln.DE [134.95.212.1]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id KAA13761; Fri, 6 Sep 1996 10:12:01 -0700 (PDT) Received: from x14.mi.uni-koeln.de (annexr3-4.slip.Uni-Koeln.DE) by FileServ1.MI.Uni-Koeln.DE with SMTP id AA14289 (5.67b/IDA-1.5); Fri, 6 Sep 1996 19:11:51 +0200 Received: (from se@localhost) by x14.mi.uni-koeln.de (8.7.5/8.6.9) id TAA16633; Fri, 6 Sep 1996 19:08:57 +0200 (MET DST) Date: Fri, 6 Sep 1996 19:08:57 +0200 (MET DST) Message-Id: <199609061708.TAA16633@x14.mi.uni-koeln.de> From: Stefan Esser To: "Rodney W. Grimes" Cc: rgrimes@freefall.freebsd.org (Rodney W. Grimes), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci pcisupport.c In-Reply-To: <199609060932.CAA12748@GndRsh.aac.dev.com> References: <199609060917.CAA07110@freefall.freebsd.org> <199609060932.CAA12748@GndRsh.aac.dev.com> Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Rodney W. Grimes writes: > > rgrimes 96/09/06 02:17:09 > > > Looking at this file and all the #if defined (I686_CPU) cruft and the > ordering of chipsets makes me want a cleaner approach. Also you have > to be _VERY_ carefull on what you exclude from certain CPU classes, > especially with devices other than HOST/PCI bridges (ie, a PCI/anything > bridge _can_ be used with _ANY_ cpu class. Well, I did make sure I got that right, but the #if defined (Ix86_CPU) will all go away again, since it was an outright silly idea ... See my reply to Michael Smith, who rightly complained about his, too ... > Stephan, do you really want to be doing that in here?? No, I really don't, anymore ... I'll back those changes out, if you don't beat me on it (which shouldn't be too hard given your much better connectivity to Freefall :) Regards, STefan