From owner-freebsd-net@FreeBSD.ORG Tue Jun 12 17:43:38 2012 Return-Path: Delivered-To: net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3A32106567A; Tue, 12 Jun 2012 17:43:38 +0000 (UTC) (envelope-from gperez@entel.upc.edu) Received: from violet.upc.es (violet.upc.es [147.83.2.51]) by mx1.freebsd.org (Postfix) with ESMTP id 260B98FC1B; Tue, 12 Jun 2012 17:43:37 +0000 (UTC) Received: from ackerman2.upc.es (ackerman2.upc.es [147.83.2.244]) by violet.upc.es (8.14.1/8.13.1) with ESMTP id q5CHhUlw021496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 12 Jun 2012 19:43:30 +0200 Received: from [192.168.1.128] ([80.31.158.180]) (authenticated bits=0) by ackerman2.upc.es (8.14.4/8.14.4) with ESMTP id q5CHhRaH020489 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 12 Jun 2012 19:43:29 +0200 References: In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <20D4B9A0-15D2-439A-99E1-0FD577385C98@entel.upc.edu> X-Mailer: iPhone Mail (9B206) From: Gustau Perez Date: Tue, 12 Jun 2012 19:43:26 +0200 To: Andrew Thompson X-Scanned-By: MIMEDefang 2.70 on 147.83.2.244 X-Mail-Scanned: Criba 2.0 + Clamd X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (violet.upc.es [147.83.2.51]); Tue, 12 Jun 2012 19:43:30 +0200 (CEST) Cc: "net@freebsd.org" Subject: Re: Panic with if_bridge when removing components X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2012 17:43:38 -0000 Enviat des del meu iTotxo (disculpeu la brevetat) Sent from my iBrick (excuse me for the brief message) El 10/06/2012, a les 22:49, Andrew Thompson va escriur= e: > On 10 June 2012 02:27, Gustau Perez Querol wrote: >> Hi, >>=20 >> I'm seeing panics when removing an interface of a bridge. The system run= s >> HEAD/AMD64 r236733. I see no changes to if_bridge.c in the last two days,= so >> I would say the problem's still there. I also checked stable and the prob= lem >> should be there too. >>=20 >> The problem is that I have a bridge composed of two ethernet interfaces,= an >> ath interface and a tap. As soon as I remove any of them the system panic= s. >> Because the system runs openvpn with the tap connected to the bridge, whe= n >> the system starts to reboot, the openvpn daemon removes the tap and thus >> causing also the panic. >>=20 >> The panic comes because at sys/net/if_bridge.c:943 the struct >> *ifnet->if_bridge of the interface removed is set to NULL too early. Beca= use >> of this, at sys/net/if_bridge.c:996 we call if_bridge.c:bridge_linkstate >> where the struct *ifnet->if_bridge is needed. This causes the panic. >=20 >=20 > I introduced this issue in r234487, please try this patch. > http://people.freebsd.org/~thompsa/bridge_link.diff >=20 > regards, > Andrewb=20 Wasn't unable to test until now. I've seen it was comitted to head wester= day. I've read the diff and I haven't seen problems so the changes and the M= FC look good to me too. Thanks, Gustau=