Date: Tue, 12 Jun 2012 19:43:26 +0200 From: Gustau Perez <gperez@entel.upc.edu> To: Andrew Thompson <thompsa@FreeBSD.org> Cc: "net@freebsd.org" <net@FreeBSD.org> Subject: Re: Panic with if_bridge when removing components Message-ID: <20D4B9A0-15D2-439A-99E1-0FD577385C98@entel.upc.edu> In-Reply-To: <CAFAOGNRdNDV3JooR5hMjtD1W%2B8BkZU0U_8=CZLFgyimft6VEog@mail.gmail.com> References: <c3457a59051eba45d2204aa1fb7388db@webmail.entel.upc.edu> <CAFAOGNRdNDV3JooR5hMjtD1W%2B8BkZU0U_8=CZLFgyimft6VEog@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Enviat des del meu iTotxo (disculpeu la brevetat) Sent from my iBrick (excuse me for the brief message) El 10/06/2012, a les 22:49, Andrew Thompson <thompsa@FreeBSD.org> va escriur= e: > On 10 June 2012 02:27, Gustau Perez Querol <gperez@entel.upc.edu> wrote: >> Hi, >>=20 >> I'm seeing panics when removing an interface of a bridge. The system run= s >> HEAD/AMD64 r236733. I see no changes to if_bridge.c in the last two days,= so >> I would say the problem's still there. I also checked stable and the prob= lem >> should be there too. >>=20 >> The problem is that I have a bridge composed of two ethernet interfaces,= an >> ath interface and a tap. As soon as I remove any of them the system panic= s. >> Because the system runs openvpn with the tap connected to the bridge, whe= n >> the system starts to reboot, the openvpn daemon removes the tap and thus >> causing also the panic. >>=20 >> The panic comes because at sys/net/if_bridge.c:943 the struct >> *ifnet->if_bridge of the interface removed is set to NULL too early. Beca= use >> of this, at sys/net/if_bridge.c:996 we call if_bridge.c:bridge_linkstate >> where the struct *ifnet->if_bridge is needed. This causes the panic. >=20 >=20 > I introduced this issue in r234487, please try this patch. > http://people.freebsd.org/~thompsa/bridge_link.diff >=20 > regards, > Andrewb=20 Wasn't unable to test until now. I've seen it was comitted to head wester= day. I've read the diff and I haven't seen problems so the changes and the M= FC look good to me too. Thanks, Gustau=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20D4B9A0-15D2-439A-99E1-0FD577385C98>