From owner-svn-src-head@freebsd.org Wed Nov 22 00:08:24 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 268C6DBBB0D; Wed, 22 Nov 2017 00:08:24 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 09F5F63F0E; Wed, 22 Nov 2017 00:08:23 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id vAM08HEu074043 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Nov 2017 16:08:17 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id vAM08GQl074042; Tue, 21 Nov 2017 16:08:16 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 21 Nov 2017 16:08:16 -0800 From: Gleb Smirnoff To: Marcin Wojtas , Michal Krawczyk Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325239 - head/sys/dev/ena Message-ID: <20171122000816.GH1063@FreeBSD.org> References: <201710311631.v9VGVNOs058255@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201710311631.v9VGVNOs058255@repo.freebsd.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 00:08:24 -0000 Hi Martin and Michal, On Tue, Oct 31, 2017 at 04:31:23PM +0000, Marcin Wojtas wrote: M> Author: mw M> Date: Tue Oct 31 16:31:23 2017 M> New Revision: 325239 M> URL: https://svnweb.freebsd.org/changeset/base/325239 M> M> Log: M> Rework counting of hardware statistics in ENA driver M> M> Do not read all statistics from the device, instead count them in the M> driver except from RX drops - they are received directly from the NIC M> in the AENQ descriptor. M> M> Submitted by: Michal Krawczyk M> Reviewed by: imp M> Obtained from: Semihalf M> Sponsored by: Amazon.com, Inc. M> Differential Revision: https://reviews.freebsd.org/D12852 Is it possible not to count them in software, as well as not fetch them from hardware periodically, but instead just fetch them on demand, when either if_get_counter() or a sysctl is called? That would be more efficient. -- Gleb Smirnoff