From owner-svn-src-head@freebsd.org Thu Jan 5 06:35:20 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9A47C9F91D; Thu, 5 Jan 2017 06:35:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B9A0C15CB; Thu, 5 Jan 2017 06:35:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x242.google.com with SMTP id 127so18057151pfg.0; Wed, 04 Jan 2017 22:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=EXEHcEIRYxEmYZhQij8PfXwQ+TWbchLtyt+dXVBrVmU=; b=jC7T4uLVhn+dzMYQSSP2nBSG1jmjpxtoaAVdp6+8PEZ2vc0nCyk+S13yIMCdD2gkdk wD30vx8TYyhIocw8WfKnwVB6QJXCeDI9VNzU9tGne0imjmWOvhqnQc4CS10vVY/z3Myh 3HQN9dtfeAmri21Xb6atTN+CGNZljvs9y6g3OaLfv9WZr091cibFiobHNjhmAgsisRCS 1XvXI26FPbgKfBKxJDGvJJbERJmaGHeULNAOIoG9eZxN+yekKBA3HPgQOl4oEFtO8x+e xydUksNO4TXc/YMZ2vpCtIEOC24dOVgqqt8iO68LVYPhp7JG6/i/T9s0D4K3CyEbQ4h8 6dUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=EXEHcEIRYxEmYZhQij8PfXwQ+TWbchLtyt+dXVBrVmU=; b=M+5JBCGeJ+To7VJ7VydTdqwPpmjHTqbqq7MejWZgSTbh3FdK8mV8bNsaAfXI5OeRCu HfShKS0e8vIvDe1KPN6WmJOdYhpAg3c8/vccZ/A5Cr+u2HYzu9crbBDkWpTIYLR3rdTD XpNH4V/Sv8vMOl/nvh8ENiwd3OJiyuQSu5Xl1rnnmd7SjqBVPoHbB4V6hcXu45Fm+oXu OHUAwXi/mTDeNF77u0GvH6hRTx8x0ToWC9PZseKQxy809GEzipZmfNU3gsb9wMRMCaD5 ZhuHSHgwk5vuxWfGZkfQuHunYdHRK0eYWBjAK+Uis8cbpm01l209a1XTV3gm99+EQMgP 4PcA== X-Gm-Message-State: AIkVDXI53H0ASXK3NX4vf1wZW0c4MT9dMJiRAjS3j9ZKUjQisn/MjUpPGmuL0iW5Z3P1xg== X-Received: by 10.84.142.131 with SMTP id 3mr153375876plx.124.1483598120320; Wed, 04 Jan 2017 22:35:20 -0800 (PST) Received: from ?IPv6:2607:fb90:80b1:1aa9:91a9:7481:6851:3188? ([2607:fb90:80b1:1aa9:91a9:7481:6851:3188]) by smtp.gmail.com with ESMTPSA id k22sm93474049pfg.84.2017.01.04.22.35.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2017 22:35:19 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r311233 - head/contrib/netbsd-tests/fs/tmpfs From: Ngie Cooper X-Mailer: iPhone Mail (14C92) In-Reply-To: <20170104233650.GB17765@stack.nl> Date: Wed, 4 Jan 2017 22:35:18 -0800 Cc: Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <340662A0-12F5-46A1-AEA0-CFC62732F91B@gmail.com> References: <201701040246.v042kaEh039041@repo.freebsd.org> <20170104233650.GB17765@stack.nl> To: Jilles Tjoelker X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 06:35:21 -0000 > On Jan 4, 2017, at 15:36, Jilles Tjoelker wrote: ... > It would be better to avoid naming the non-portable sun_len field if it > is just to make Coverity happy. I suggest initializing the structure > with designated initializers or memset(). >=20 > Apart from that, the value for sun_len is wrong; it should be the length > of the whole structure and not just the sun_path part. Fortunately, the > field is ignored by bind(), which uses the addrlen parameter instead. >=20 > On a more general note, refactoring tests without a way to verify they > have not been changed to always pass is risky :( Yeah... agreed. Unfortunately, the interest in reviewing tests is low.. some= people only care when they "break" :(.. In general, I try to test all of my changes carefully, but this item fell th= rough the cracks, due to my poor memory about how sockaddr_un is structured.= Thank you for the input jilles and jmallett! > --=20 > Jilles Tjoelker