From owner-svn-soc-all@freebsd.org  Tue Dec  1 22:44:53 2015
Return-Path: <owner-svn-soc-all@freebsd.org>
Delivered-To: svn-soc-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CC01A3E1C2
 for <svn-soc-all@mailman.ysv.freebsd.org>;
 Tue,  1 Dec 2015 22:44:53 +0000 (UTC) (envelope-from def@FreeBSD.org)
Received: from socsvn.freebsd.org (socsvn.freebsd.org
 [IPv6:2001:1900:2254:206a::50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7CAB7100F
 for <svn-soc-all@FreeBSD.org>; Tue,  1 Dec 2015 22:44:53 +0000 (UTC)
 (envelope-from def@FreeBSD.org)
Received: from socsvn.freebsd.org ([127.0.1.124])
 by socsvn.freebsd.org (8.15.2/8.15.2) with ESMTP id tB1MirQm099144
 for <svn-soc-all@FreeBSD.org>; Tue, 1 Dec 2015 22:44:53 GMT
 (envelope-from def@FreeBSD.org)
Received: (from www@localhost)
 by socsvn.freebsd.org (8.15.2/8.15.2/Submit) id tB1Miqbc099071
 for svn-soc-all@FreeBSD.org; Tue, 1 Dec 2015 22:44:52 GMT
 (envelope-from def@FreeBSD.org)
Date: Tue, 1 Dec 2015 22:44:52 GMT
Message-Id: <201512012244.tB1Miqbc099071@socsvn.freebsd.org>
X-Authentication-Warning: socsvn.freebsd.org: www set sender to
 def@FreeBSD.org using -f
From: def@FreeBSD.org
To: svn-soc-all@FreeBSD.org
Subject: socsvn commit: r294717 - soc2013/def/crashdump-head/sbin/decryptcore
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-soc-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the entire Summer of Code repository
 <svn-soc-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-soc-all/>
List-Post: <mailto:svn-soc-all@freebsd.org>
List-Help: <mailto:svn-soc-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2015 22:44:53 -0000

Author: def
Date: Tue Dec  1 22:44:52 2015
New Revision: 294717
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=294717

Log:
  Add a comment why decryptcore decrypts a core dump in a separate process.

Modified:
  soc2013/def/crashdump-head/sbin/decryptcore/decryptcore.c

Modified: soc2013/def/crashdump-head/sbin/decryptcore/decryptcore.c
==============================================================================
--- soc2013/def/crashdump-head/sbin/decryptcore/decryptcore.c	Tue Dec  1 22:35:10 2015	(r294716)
+++ soc2013/def/crashdump-head/sbin/decryptcore/decryptcore.c	Tue Dec  1 22:44:52 2015	(r294717)
@@ -127,7 +127,8 @@
 	privkey = NULL;
 
 	/*
-	 * TODO: comment.
+	 * Decrypt a core dump in a child process so we can unlink a partially
+	 * decrypted core if the child process fails.
 	 */
 	pid = fork();
 	if (pid == -1) {