From owner-cvs-all@FreeBSD.ORG Tue Jun 5 08:24:27 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 438B216A400; Tue, 5 Jun 2007 08:24:27 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id E710213C447; Tue, 5 Jun 2007 08:24:26 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 05DFD472A8; Tue, 5 Jun 2007 04:24:26 -0400 (EDT) Date: Tue, 5 Jun 2007 09:24:25 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John-Mark Gurney In-Reply-To: <20070605050351.GJ4602@funkthat.com> Message-ID: <20070605092255.L76940@fledge.watson.org> References: <200706041825.l54IP8RD042273@repoman.freebsd.org> <20070605050351.GJ4602@funkthat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Malone , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 tsc.c src/sys/amd64/isa clock.c src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.c src/sys/compat/opensolaris/kern opensolaris_kstat.c src/sys/dev/acpica acpi_timer.c src/sys/dev/bge if_bge.c src/sys/dev/sound clone.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2007 08:24:27 -0000 On Mon, 4 Jun 2007, John-Mark Gurney wrote: > David Malone wrote this message on Mon, Jun 04, 2007 at 18:25 +0000: >> Log: >> Despite several examples in the kernel, the third argument of >> sysctl_handle_int is not sizeof the int type you want to export. >> The type must always be an int or an unsigned int. >> >> Remove the instances where a sizeof(variable) is passed to stop >> people accidently cut and pasting these examples. >> >> In a few places this was sysctl_handle_int was being used on 64 bit >> types, which would truncate the value to be exported. In these >> cases use sysctl_handle_quad to export them and change the format >> to Q so that sysctl(1) can still print them. > > Perhaps documenting SYSCTL_HANDLER_ARGS and the several standard handlers in > sysctl_add_oid(9) would be in order? Or even in sysctl(9). Robert N M Watson Computer Laboratory University of Cambridge