From owner-cvs-sys Tue Oct 28 08:00:38 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id IAA00684 for cvs-sys-outgoing; Tue, 28 Oct 1997 08:00:38 -0800 (PST) (envelope-from owner-cvs-sys) Received: from Kitten.mcs.com (Kitten.mcs.com [192.160.127.90]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id HAA00516; Tue, 28 Oct 1997 07:58:05 -0800 (PST) (envelope-from nash@Jupiter.Mcs.Net) Received: from Jupiter.Mcs.Net (nash@Jupiter.mcs.net [192.160.127.88]) by Kitten.mcs.com (8.8.5/8.8.2) with ESMTP id JAA19077; Tue, 28 Oct 1997 09:58:04 -0600 (CST) Received: from localhost (nash@localhost) by Jupiter.Mcs.Net (8.8.7/8.8.2) with SMTP id JAA21902; Tue, 28 Oct 1997 09:58:03 -0600 (CST) Date: Tue, 28 Oct 1997 09:58:03 -0600 (CST) From: Alex Nash To: Darren Reed cc: Bill Fenner , guido@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_input.c In-Reply-To: <199710281021.VAA27329@plum.cyber.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Tue, 28 Oct 1997, Darren Reed wrote: > In some mail I received from Bill Fenner, sie wrote > [...] > > However, there is a problem with the actual change: the "goto" bypasses > > the strcpy() which gives log() something to print. In addition, the whole > > log(LOG_WARNING, ...) for each packet provides a wonderful denial of service > > attack (I understand this isn't new with this commit, but it's still an > > issue). > > At least log() is used and you have a chance to redirect it via syslogd(?) to > a file...if you relied on ipfw using printf, everything would go out via the > console. Kernel printf is sent to both the console and the logger. Alex