From nobody Wed Dec 28 09:04:08 2022 X-Original-To: pf@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NhlvD1yPCz2cHq6 for ; Wed, 28 Dec 2022 09:04:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NhlvD0v8bz46wm for ; Wed, 28 Dec 2022 09:04:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672218248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6uM8x2gDoG3nI7WaAV/HF6rrm/YjcIxq7FkqxEu1jpw=; b=EZBYI+sYRJFzzJL6vSuq7W27aPa8DPKcUWMS3FnimR3KLowwhwzm1qEuD9YnDhuGnGgojd BFk3IdwEEEdgCxpNwArYD67Ay5Ve8T9LhpCQ6SsTPgV5ClOhWtx4Qc07hKSG6Xgv+MocDa OXGxfCOqS1LRZ3hyuZkDCZKqbqck7MOWtCkENKGvoiVxNoWfwqMC+FUQRP49Ra7J/u4hEX YvvrwZvHhlb87I/QvNGCF+jIvK3nSV7P3Koxh/q/LM0x1tvgTKRQtHxBxEj7wpJaSZReFL gkP0AdvvDIqFZ4sRxAyXxQGuKK7FAisKLDQPCBdng9F3AVSM6QQbVEQxrDPgpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672218248; a=rsa-sha256; cv=none; b=Wmm+UEHCjk8ytbq0o8/3bCJqIx64sFypQ/h/lYnBVGRuBOMHBzOfbPcCqTMaeIP3pvnqiv I5YSM9b1FqeFvH/FR0e3UzH+esekzobHVcRDcK1SoaNKhtn+vAwJGLoRTaJ3L3F3hfftiN 4MHoCKxKDKJlPHRWz69/bxHop1+chdbWVQ3dY8U1yip4aGgWI9Nf2CtMuRsBkJXoItDprE L+raQuf5TuYTaxiv6Gg3hBDIkM95v9useR06toZFgXbgeTq5oKKjZxkFP1vNqCa6cogWp7 CvptTtQtz7AzJbDzqOSgdnfbS9QHnh6SZ9jxQj0/ip/iTNwsTqihzFF6vqPWTw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NhlvC74HszkMZ for ; Wed, 28 Dec 2022 09:04:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2BS947k7003104 for ; Wed, 28 Dec 2022 09:04:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2BS947u0003103 for pf@FreeBSD.org; Wed, 28 Dec 2022 09:04:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 257218] pfi_ifnet leak on interface removal Date: Wed, 28 Dec 2022 09:04:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Technical discussion and general questions about packet filter (pf) List-Archive: https://lists.freebsd.org/archives/freebsd-pf List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pf@freebsd.org X-BeenThere: freebsd-pf@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257218 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D5f7454d8904ca68697dda569f71af6ef5= ec178c7 commit 5f7454d8904ca68697dda569f71af6ef5ec178c7 Author: Nick Reilly AuthorDate: 2022-11-30 14:19:44 +0000 Commit: Kristof Provost CommitDate: 2022-12-28 04:56:08 +0000 pf: fix pfi_ifnet leak on interface removal The detach of the interface and group were leaving pfi_ifnet memory behind. Check if the kif still has references, and clean it up if it doesn't On interface detach, the group deletion was notified first and then a change notification was sent. This would recreate the group in the kif layer. Reorder the change to before the delete. PR: 257218 MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D37569 (cherry picked from commit bfeef0d32a0036bf6bec93a439e0466efe6f4482) sys/net/if.c | 3 +-- sys/netpfil/pf/pf_if.c | 23 ++++++++++++++++++----- 2 files changed, 19 insertions(+), 7 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=