From nobody Tue Jan 21 14:09:02 2025 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcpwZ5tgBz5l8Pp for ; Tue, 21 Jan 2025 14:09:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcpwZ5K6xz41c2 for ; Tue, 21 Jan 2025 14:09:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737468542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PpHy6QpOJoKI76F0mhvhdht4O2XvyqRGiSYSE8/o/ew=; b=Q2Ha+tfA3UPSZk0rqonuhRw28hbxy5KFYWMrbDcvM8rAxWATY/b92MkLuULv4N6AJ+B2e4 gp4mBxIbmyKRwpNZRZo6eHQRUVey9LSq5dAJovTp30yrXisYnJl3sThSRyJ+E6UFYQVHSz m+NH9ldwRdBT0dNDjrcAf3iV0cisB1hduiT+xdlFGiHqk4gI3hbvV+svoR/Ru3tfSu+Qre NIQoRndHTMEc13I95R16YXjT8H4oaaEMRTpd00QEmDDeWujXubgFTFYjaf9FuhaGx0zf+x DCv6GbUJxOZtgsDGlZ8KCvzCu6Zoxfp9cO0lMUoMGAqgTAzxEeAtzgRprHxtow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737468542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PpHy6QpOJoKI76F0mhvhdht4O2XvyqRGiSYSE8/o/ew=; b=ZMow/kcH+DPdhbwqBTcy9pOA4BHJOTR46jVpS+4CmqJK3CQHpfS9g03Wexpd2PYQinh+xy Iu/DK2UATzEQXB4In83CsAz6x9swctNI2Hyaz8BT6q4YdlpIhZe+XKaQIa5+Lz31JZFCko C0QRtytkEL/DY2v074y1Z2qs7+Mz84vFwvkNgnjCD3ClM6KlGkBd9lH6DCnLOq3EJnnZSV xVt1dQF5LXFpH10rnA61Z3U+2EuHoTaKnJD8EuODTCHQ4da7q/IPRY3yn99OMvQWkXnYn+ nZqJkLRlB6A1vFFj+KxCu7m/gpcZ6Vd6bEMHugx3uajRLP8JOjFENmPAYnJhjA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737468542; a=rsa-sha256; cv=none; b=ApRei6QiV4thz2jchTPn2fWXbprxtltl7qOpiYVumK+Zd9oTWLYcTGd/DU8e1KKAZD4uba i9jHc7MMkCZxNEsDp+eHBqr5TTw8/3LH+gKPproTSZjPqFoHsru9N1RK3Ex05Zjfgk7EZv ld5rmozIJqSO4aDNnEq+U6Tsn+V1kc+eIbDNoxBZCcdVaKVGHH3cbyV8YV2UVoupN7sOaJ 89FPd+Vq6c943+tjCcxNV6UniIW5JbbyGMVwylnoauHt1oEXSDUn2Imkp/jOmF2hiuSMed Q5b2PX/FLzU6pa7AzpUFqwL7qwLhaYcfW8EnbrwrlvmfDO+WZ37/BhXLXWOo0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YcpwZ4TNwz18Qj for ; Tue, 21 Jan 2025 14:09:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50LE92Qe093305 for ; Tue, 21 Jan 2025 14:09:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50LE92de093303 for fs@FreeBSD.org; Tue, 21 Jan 2025 14:09:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 283583] makefs(8) -t zfs Assertion on unexpected devfs mount in directory Date: Tue, 21 Jan 2025 14:09:02 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.2-RELEASE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: markj@FreeBSD.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283583 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D0ec93987e5302495f9512f8534a2375d7= da4ee2a commit 0ec93987e5302495f9512f8534a2375d7da4ee2a Author: Mark Johnston AuthorDate: 2025-01-07 14:31:02 +0000 Commit: Mark Johnston CommitDate: 2025-01-21 14:08:40 +0000 makefs: Handle special file types when creating a zpool Previously, anything other than a regular file, directory or symlink would cause makefs to exit with an assertion failure. Make it a bit more resilient to user error: print a warning and skip the file. Add a regression test wherein we create an image from a devfs mount. PR: 283583 MFC after: 2 weeks (cherry picked from commit ce878284318e71217d8d8f43f7d590b6c338d3aa) usr.sbin/makefs/tests/makefs_zfs_tests.sh | 22 +++++++++++++++++ usr.sbin/makefs/zfs/fs.c | 39 +++++++++++++++++++++++++--= ---- 2 files changed, 54 insertions(+), 7 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=