From owner-svn-src-user@FreeBSD.ORG Wed May 18 19:55:44 2011 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50DBF1065673; Wed, 18 May 2011 19:55:44 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 351A78FC08; Wed, 18 May 2011 19:55:42 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA27766; Wed, 18 May 2011 22:55:41 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1QMmqL-000B3p-7l; Wed, 18 May 2011 22:55:41 +0300 Message-ID: <4DD4243C.4070301@FreeBSD.org> Date: Wed, 18 May 2011 22:55:40 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110503 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201105181508.p4IF8UoS096841@svn.freebsd.org> <20110518182441.GB2273@garage.freebsd.pl> In-Reply-To: <20110518182441.GB2273@garage.freebsd.pl> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r222060 - in user/avg/xcpu/sys: kern sys X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2011 19:55:44 -0000 on 18/05/2011 21:24 Pawel Jakub Dawidek said the following: > On Wed, May 18, 2011 at 03:08:30PM +0000, Andriy Gapon wrote: > [...] >> --- user/avg/xcpu/sys/sys/proc.h Wed May 18 15:07:36 2011 (r222059) >> +++ user/avg/xcpu/sys/sys/proc.h Wed May 18 15:08:30 2011 (r222060) >> @@ -781,7 +781,7 @@ MALLOC_DECLARE(M_SUBPROC); >> * Otherwise, the kernel will deadlock since the scheduler isn't >> * going to run the thread that holds the lock we need. >> */ >> -#define THREAD_PANICED() \ >> +#define TD_IS_INPANIC() \ >> (panicstr != NULL && (curthread->td_flags & TDF_INPANIC) != 0) > > Does TDF_INPANIC make sense without panicstr being set? Very good observation. It seems that TDF_INPANIC can never be set unless panicstr is set. So, I guess it should be OK to simplify the macro further. Thank you. -- Andriy Gapon