From owner-svn-src-head@freebsd.org  Wed Mar 21 15:03:24 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9BB6F4AEF4;
 Wed, 21 Mar 2018 15:03:24 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: from mail-it0-f45.google.com (mail-it0-f45.google.com
 [209.85.214.45])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 660A073EAE;
 Wed, 21 Mar 2018 15:03:24 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: by mail-it0-f45.google.com with SMTP id b136-v6so7270242iti.3;
 Wed, 21 Mar 2018 08:03:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:reply-to:in-reply-to:references
 :from:date:message-id:subject:to:cc;
 bh=sf5gqIOw/cFJO/zO8WIY/nChpEWzJiSlQ1PWwP0HQRc=;
 b=Vg8hQ/1FrrvGwW+TWvF3WAFC6nOqKX6aALr0PiRDIeVAX/fdBzRI04cm0njp49OYjH
 +cMY7L0Xib0//XHux+efXE7R67S4abF1MAdnNaRs5vX2ohEgPMxwQT+bB0exGXxGr5o9
 /vlM+Oe9md0p1HmekDzegbeTfrB5d3RPeOMlAffjMXZSXvEGfoVYLCXV8EzS39lHR80z
 1LnVrYx70A34kOiCsFR+zywc836Wicaa1YRRaZRN2LPUUEWoe6uAzzARd7QOwpjjQOwN
 7aZ1aysxmZinavkt5rpo5x1BN8oHU4gQ4RCVUXltbdzBP0l0+Z4tU40KvJvOabg1iNP2
 soVw==
X-Gm-Message-State: AElRT7EP1hxxpfqIuKxeS5t3RDLLue0/sxaCa1ie6BYN7cdGuS698wHW
 ivNpbNMQODg3d3CDYImrtLq1zsG1
X-Google-Smtp-Source: AG47ELu/bW2NDPol7vyRPGoOWQSszTU9E9sn60C0/JZ8bOOkFEguUW2VFbtYMSAuYwEC5BGs5ylbew==
X-Received: by 2002:a24:2c8:: with SMTP id
 191-v6mr4566968itu.108.1521644597462; 
 Wed, 21 Mar 2018 08:03:17 -0700 (PDT)
Received: from mail-it0-f41.google.com (mail-it0-f41.google.com.
 [209.85.214.41])
 by smtp.gmail.com with ESMTPSA id b34-v6sm2389989itd.12.2018.03.21.08.03.16
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 21 Mar 2018 08:03:17 -0700 (PDT)
Received: by mail-it0-f41.google.com with SMTP id p67-v6so2221905itc.2;
 Wed, 21 Mar 2018 08:03:16 -0700 (PDT)
X-Received: by 2002:a24:e14e:: with SMTP id
 n75-v6mr3473776ith.58.1521644596835; 
 Wed, 21 Mar 2018 08:03:16 -0700 (PDT)
MIME-Version: 1.0
Reply-To: cem@freebsd.org
Received: by 10.2.153.132 with HTTP; Wed, 21 Mar 2018 08:03:16 -0700 (PDT)
In-Reply-To: <20180321103325.GJ76926@kib.kiev.ua>
References: <201803210115.w2L1Fjt9084698@repo.freebsd.org>
 <20180321103325.GJ76926@kib.kiev.ua>
From: Conrad Meyer <cem@freebsd.org>
Date: Wed, 21 Mar 2018 08:03:16 -0700
X-Gmail-Original-Message-ID: <CAG6CVpW3tPVyh6D3FXpAc9DPqG9u_KnHBiZOFmg1zZsHmDb8jA@mail.gmail.com>
Message-ID: <CAG6CVpW3tPVyh6D3FXpAc9DPqG9u_KnHBiZOFmg1zZsHmDb8jA@mail.gmail.com>
Subject: Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys
 lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys
 tests/sys/kern usr.bin/truss
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2018 15:03:25 -0000

On Wed, Mar 21, 2018 at 3:33 AM, Konstantin Belousov
<kostikbel@gmail.com> wrote:
> On Wed, Mar 21, 2018 at 01:15:45AM +0000, Conrad Meyer wrote:
>> +int
>> +getentropy(void *buf, size_t buflen)
>> +{
>> +     ssize_t rd;
>> +
>> +     if (buflen > 256) {
>> +             errno = EIO;
>> +             return (-1);
>> +     }
>> +
>> +     while (buflen > 0) {
>> +             rd = getrandom(buf, buflen, 0);
>> +             if (rd == -1) {
>> +                     if (errno == EINTR)
>> +                             continue;
>> +                     else if (errno == ENOSYS)
>> +                             abort();
> Libraries must not abort the application.
> Esp. libc.

What do you propose instead?  while (1); ?  I don't see that as
obviously better.

>> ...
>> @@ -627,6 +628,8 @@ FBSDprivate_1.0 {
>>       __sys_getppid;
>>       _getpriority;
>>       __sys_getpriority;
>> +     _getrandom;
>> +     __sys_getrandom;
>>       _getresgid;
>>       __sys_getresgid;
>>       _getresuid;
>
> Is there any use planned for _getrandom and for __sys_ ?  If not,
> we do not add private symbols for newer syscalls in recent times.

Nope, just following the pattern.  They can be removed if they are not needed.

Best,
Conrad