From owner-freebsd-arch@FreeBSD.ORG Thu Jun 7 07:04:59 2007 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3FACE16A468 for ; Thu, 7 Jun 2007 07:04:59 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id E753C13C447 for ; Thu, 7 Jun 2007 07:04:58 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 5BD908BDC3F; Thu, 7 Jun 2007 09:04:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RUdjiTYB4njn; Thu, 7 Jun 2007 09:04:56 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 56E8E8BDC2D; Thu, 7 Jun 2007 09:04:56 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l5774t7P071117; Thu, 7 Jun 2007 09:04:55 +0200 (CEST) (envelope-from rdivacky) Date: Thu, 7 Jun 2007 09:04:55 +0200 From: Roman Divacky To: Doug Barton Message-ID: <20070607070455.GA71012@freebsd.org> References: <20070604162430.GA76813@freebsd.org> <896DB1FBFFD5A145833D9DA08CA12A85051A7F@seaxch07.desktop.isilon.com> <20070606074429.GA42032@freebsd.org> <4666F0FB.8020101@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4666F0FB.8020101@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: Eric Lemar , arch@FreeBSD.org Subject: Re: *at family of syscalls in FreeBSD X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2007 07:04:59 -0000 On Wed, Jun 06, 2007 at 10:38:03AM -0700, Doug Barton wrote: > Roman Divacky wrote: > > > my current patch is at: www.vlakno.cz/~rdivacky/linux_at.patch > > > > it does not implement the native fbsd syscalls, only the linuxulator ones > > but adding those is a matter of minutes. I asked for a review by pjd and/or > > rwatson and hopefully this will get commited soon.. > > My recollection of the last round of discussion was that you were > asked to implement these in our base, then wrap the linux versions. If > it's trivial to implement, it should probably be done that way first. well.. my implementation does exactly that :) I changed namei() routine to check ni_startdir for possible startdir other then CWD and made the kern_fooat() use it. the change is mostly self-contained (minus prototypes in sys/sys/syscallsubr.h) in vfs_syscalls. with a very slight change (5 lines?) to vfs_lookup.c + namei.h its quite simple. I cant comment the Isilon's version. My patch (the approach) has been OKed by rwatson@ and pjd@. I'd really love to see this go to -current before RELENG_7 so time is rushing. can someone from Isilon comment their version so we can compare benefits etc.? roman