From owner-svn-src-all@FreeBSD.ORG Thu Aug 2 21:25:41 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EB63A1065673; Thu, 2 Aug 2012 21:25:41 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from mail-qa0-f54.google.com (mail-qa0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2BA7E8FC1E; Thu, 2 Aug 2012 21:25:40 +0000 (UTC) Received: by qaat11 with SMTP id t11so1903445qaa.13 for ; Thu, 02 Aug 2012 14:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=1b/HY9mjcpHHMvTV72x2fWHskTI+0Y9LCxBi8iVc3QE=; b=aBlJP+KyCJI6PyCtYOKUn0rq1kaSgx7pTIqzcDvpfhKJ8YNbWL3iPc84VbT1QmrUE/ 0xLH92Du8Oul/nCpniuXxg0o8pOBmRJ5TMghAD7CVnHf+erOxvvy0aCuR9t/1mae7MTf TWSWuiwNYzA4QiVxLHPA/MA78t8VoArhBg0QomQsqKe9UGFeQLWedLk2CgiOoJ8O+E5x tQUtkim5bQt0FLEdEYvxA+OPg3/36T5sXUzu+hljJsDm0b4w6vqo1AfjoQGhTniAzgpg WW6vy4dOnTVF2RHeilR0rSDUohkt1/suncfLcYQPgHDoxJO625B+66tyeelR7xYADN2Z nBHA== MIME-Version: 1.0 Received: by 10.224.1.130 with SMTP id 2mr43996191qaf.61.1343942740072; Thu, 02 Aug 2012 14:25:40 -0700 (PDT) Sender: maksim.yevmenkin@gmail.com Received: by 10.224.216.72 with HTTP; Thu, 2 Aug 2012 14:25:40 -0700 (PDT) In-Reply-To: <20120803.055554.1380323232583218022.hrs@allbsd.org> References: <201207191536.q6JFabOR094467@svn.freebsd.org> <20120803.055554.1380323232583218022.hrs@allbsd.org> Date: Thu, 2 Aug 2012 14:25:40 -0700 X-Google-Sender-Auth: TJkYq6Yc9g9yBDXSeCfIu-rYCh0 Message-ID: From: Maksim Yevmenkin To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r238622 - head/etc/rc.d X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2012 21:25:42 -0000 On Thu, Aug 2, 2012 at 1:55 PM, Hiroki Sato wrote: > Maksim Yevmenkin wrote > in <201207191536.q6JFabOR094467@svn.freebsd.org>: > > em> Author: emax > em> Date: Thu Jul 19 15:36:36 2012 > em> New Revision: 238622 > em> URL: http://svn.freebsd.org/changeset/base/238622 > em> > em> Log: > em> Allow to specify no source-address-selection policy > em> > em> MFC after: 1 week > em> > em> Modified: > em> head/etc/rc.d/ip6addrctl > em> > em> Modified: head/etc/rc.d/ip6addrctl > em> ============================================================================== > em> --- head/etc/rc.d/ip6addrctl Thu Jul 19 14:43:46 2012 (r238621) > em> +++ head/etc/rc.d/ip6addrctl Thu Jul 19 15:36:36 2012 (r238622) > em> @@ -83,6 +83,9 @@ ip6addrctl_start() > em> # Backward compatibility when ipv6_prefer=NO > em> ip6addrctl_prefer_ipv4 > em> ;; > em> + [Nn][Oo][Nn][Ee]) > em> + ip6addrctl flush >/dev/null 2>&1 > em> + ;; > em> *) > em> warn "\$ip6addrctl_policy is invalid: ${ip6addrctl_policy}. " \ > em> " \"ipv4_prefer\" is used instead." > > Just curious, why ip6addrctl_enable=NO is not enough here? I would > like to eliminate yes/no/none keywords in $ip6addrctl_policy because > such keywords are vague. If we need the empty rule for some reason, > "empty" would be a better name for the policy, I think. i just wanted to make sure that there is a way to absolutely make sure that there is no default address selection policy installed. the wide know rule 9 of rfc 3484 is really messing things up for dns-style load balancing. even when ipv6 is not used. personally, i don't think that "none" is unreasonable word for "ip6addrctl_policy", but i don't feel particularly strongly about it. any name will do as long as original functionality is preserved. thanks, max