From owner-svn-src-head@FreeBSD.ORG Thu Feb 6 19:22:19 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 54F17818; Thu, 6 Feb 2014 19:22:19 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 281531B14; Thu, 6 Feb 2014 19:22:19 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0056FB9E0; Thu, 6 Feb 2014 14:22:17 -0500 (EST) From: John Baldwin To: Gavin Atkinson Subject: Re: svn commit: r261216 - head/sys/dev/pccbb Date: Thu, 6 Feb 2014 14:08:55 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <201401271949.s0RJnr7t067977@svn.freebsd.org> <201402041424.54122.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201402061408.55990.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 06 Feb 2014 14:22:18 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, imp@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Feb 2014 19:22:19 -0000 On Wednesday, February 05, 2014 7:26:33 pm Gavin Atkinson wrote: > On Tue, 4 Feb 2014, John Baldwin wrote: > > On Sunday, February 02, 2014 5:34:58 pm Gavin Atkinson wrote: > > > On Mon, 27 Jan 2014, John Baldwin wrote: > > > > Author: jhb > > > > Date: Mon Jan 27 19:49:52 2014 > > > > New Revision: 261216 > > > > URL: http://svnweb.freebsd.org/changeset/base/261216 > > > > > > > > Log: > > > > Explicitly enable I/O and memory decoding in the bridge's command register > > > > when activating an I/O or memory window on the CardBus bridge. > > > > > > This fixes some, but not all of my machines. One in particular, a Toshiba > > > M5 laptop, remains broken by r254263 even with this change. Specificaly, > > > the laptop does not notice when a card is inserted. > > > > > > The attached minimal patch gets things working again, though I don't know > > > if is the correct fix or if a more involved fix is required. > > > > > > dmesg before and after that patch: > > > > > > http://people.freebsd.org/~gavin/m5-dmesg-before.txt > > > http://people.freebsd.org/~gavin/m5-dmesg-after.txt > > > > > > The only difference is the cbb register dump, the one bit that I am > > > setting in the patch. > > > > Your patch effectively reverts r254263. It may be the correct thing to do, > > but the question is why. :) Can you provide 'pciconf -lbc' output for this > > device? (You can just do 'pciconf -lbc pccbb0' in HEAD now) > > Full "pciconf -lbc" output at > http://people.freebsd.org/~gavin/m5-pciconf-lbc.txt > > It's the same both with and without my hack-patch. Humm, no I/O port BAR. I found a copy of the cardbus spec online and there is nothing special that says it requires I/O decoding to be enabled. I guess add it with an XXX comment of some sort to note that at least one chipset requires this. -- John Baldwin