From owner-svn-ports-all@freebsd.org Wed Jan 23 22:00:11 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 630C914B3C7D; Wed, 23 Jan 2019 22:00:11 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A11858D167; Wed, 23 Jan 2019 22:00:10 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 611881745C; Wed, 23 Jan 2019 22:00:10 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e]) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id EF38C943CFD; Wed, 23 Jan 2019 22:00:08 +0000 (UTC) Date: Wed, 23 Jan 2019 23:00:08 +0100 From: Mathieu Arnold To: "Bradley T. Hughes" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r491058 - head/www/node8 Message-ID: <20190123220008.ctao7hiv4flbms7i@atuin.in.mat.cc> References: <201901232114.x0NLERHX020332@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3x2gkxcpp5sjkdpt" Content-Disposition: inline In-Reply-To: <201901232114.x0NLERHX020332@repo.freebsd.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: A11858D167 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.979,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 22:00:11 -0000 --3x2gkxcpp5sjkdpt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 23, 2019 at 09:14:27PM +0000, Bradley T. Hughes wrote: > Author: bhughes > Date: Wed Jan 23 21:14:27 2019 > New Revision: 491058 > URL: https://svnweb.freebsd.org/changeset/ports/491058 >=20 > Log: > www/node8: convert port to use BROKEN_SSL > =20 > Sponsored by: Miles AS >=20 > Modified: > head/www/node8/Makefile >=20 > Modified: head/www/node8/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/www/node8/Makefile Wed Jan 23 21:10:26 2019 (r491057) > +++ head/www/node8/Makefile Wed Jan 23 21:14:27 2019 (r491058) > @@ -13,6 +13,8 @@ COMMENT=3D V8 JavaScript for client and server (8.x LTS) > LICENSE=3D MIT > LICENSE_FILE=3D ${WRKSRC}/LICENSE > =20 > +BROKEN_SSL=3D libressl libressl-devel > +BROKEN_SSL_REASON=3D Node.js 8.x LTS requires OpenSSL >=3D 1.0.2 or the = BUNDLED_SSL option enabled > ONLY_FOR_ARCHS=3D aarch64 amd64 armv6 armv7 i386 powerpc64 > =20 > OPTIONS_DEFINE=3D BUNDLED_SSL DOCS NLS DTRACE > @@ -62,16 +64,6 @@ MAKE_ENV+=3D CC.host=3D${CC} CXX.host=3D${CXX} LINK.ho= st=3D${C > LIB_DEPENDS+=3D libcares.so:dns/c-ares\ > libuv.so:devel/libuv \ > libnghttp2.so:www/libnghttp2 > - > -.include > - > -.if empty(PORT_OPTIONS:MBUNDLED_SSL) > - > -.if !empty(SSL_DEFAULT:Mlibressl*) > -IGNORE=3D cannot build node.js with LibreSSL. You must enable BUNDLED_S= SL > -.endif > - > -.endif Mmmm, this is not equivalent, now, the port is always marked as BROKEN if the op uses libressl* as their default SSL library, even if BUNDLED_SSL is set. And I think the other changes to the other node* ports are also wrong for the same reason. --=20 Mathieu Arnold --3x2gkxcpp5sjkdpt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlxI4+hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjSRQ//XO3Kkym3muihxHXynwafFfro5pxKgoJUNoH3Y8EIcBowmE8qElNQ6tnf bq/pFBg0KC+gOScJTSvPyGYFZHfPH9TLa4Z6p0nXDt5UVY+Oc9GitadaxDdgxmL2 OD+n0tT3AJu2VlRzB9t6x+YSq4SV7sjgJTTK5IP7FjbwH/grzebr6/B340Xti+QI jMHYuwB9mv8rjFq809PjIO3DB/5/EZMrBfEmlfB2fGl5aOWu5snw3blumXBloTr2 tlnF/prVkZJyB4r8r3AGTnuN0MsrsIZyTtX1RuzqK7GnZODRily0ARV+vpGGQ8mi hCglIQt6WjWvg2FBAI5gAMdxaB+XEypc+vknh67OrTUW53oWbRCf5umuVUfmkVeU xknC1RB6XjQb1nMYpkAciOAfdWOkK3fScpk5GxCussd9vEdZpfBAlJhWaJvLklDw TowomZ7+y1Ix9NT+MoWThl48SQajiYhfWdlzNcYCZehkNxXSQuVfBO+kLFyI94GD 562n9gkddQSXdwR+Yyju2nf9YzymmqBSekV8i98ExbFwxCKc9nIVMD46NpQfVYpk OjnYs7RBsZKVDBUQe1YlpF8FRarQ1aivvaodHQe3kFXJZ4/HyXQdJi7f4Cy0HFUW wSFpQGiHegUCxIgDU1lRLzbpye+68QMRYNdz5XGR08an+bFFDW0= =mqM5 -----END PGP SIGNATURE----- --3x2gkxcpp5sjkdpt--