From owner-svn-src-all@freebsd.org Sun Oct 25 14:11:33 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B583744FEB0; Sun, 25 Oct 2020 14:11:33 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CK0JP2pn4z45Zg; Sun, 25 Oct 2020 14:11:33 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: by mail-yb1-xb2e.google.com with SMTP id n142so5454382ybf.7; Sun, 25 Oct 2020 07:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=f9LoMoW0jWgfOzUlGTZoJTVjPI2b5QOWd2iYbLDxhjE=; b=q9ExK2vOYQ11unHYvmLiYy81YV0EFLG/89L/tGLUJFJDsSuqtNnPW55mm3MdURH8zV iT2vANiWpmDVu1PGnipwlA3z/pBW4FzFrlgrvIlSxLwih4ccZ7ynNjgFX4hE80Cg/UMl 89HHWVnzt0u9/jtZZVWCro9NFwUaA1GoZv442RmKkQc1LPe0Weha+hZRt6B7ninyBVHO zUuLbQqnYSAvdKAQcGscD5Cw12b4kyoecCAKCsPKVtya+iC5UIjLvC9DG7L9ThXHn35j k4BStEyqLYvwdLVlzo5a1ytdJ2/F6VhoHkVFBJaPBhGPRCAzWD8D/jDmMCWOnsVGnuEm fWZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=f9LoMoW0jWgfOzUlGTZoJTVjPI2b5QOWd2iYbLDxhjE=; b=iVAjj9s4kdRxI2w2p8mM1TjlvwwvYw+LtHh3jbaSHdN8kYNy7R26peSfzkpW1UWqG+ ZB4njsJDi6SXzqCAkCgNgkDSwgbfz6ES+NgCePb5el9NVtft1X/cR1uhaQyRj6rARdRp G19JrmYb6IuOIMD/WwcNkt9qji2QmYmIMSYcAkOwEp+EWrPd+mAbdE6XHn0R/yLJnlsr DPYenEMk9kdWky3wNAexoRApPXXM0IT+feqMveHayIE2gvM6BmktKOx+0Lt7Ku2/bXpn dlytUiSuVAg6oInfn73OcpKtQvaWS4FvUgW6GH/4Wes0MMa46PWN3D4YIN+3N+d8J8jx ryIQ== X-Gm-Message-State: AOAM530isIb5He/CPIDIaN8Wm02tBgUf0JEGX0wXZah7R976cjizFlt7 YmvJHiUBgxJJiYop8W7U0+PvE/OtH6bJbyO9ElNqoHiC X-Google-Smtp-Source: ABdhPJyB4aMV0Ux6MvmtSzB8VQw2BvAkDpwyLBQc3pJKQ3UBxn4oPHMDOASLu4c2rujnd/oLptk6YiK0ZGSFgJUFDjk= X-Received: by 2002:a25:d481:: with SMTP id m123mr14121764ybf.142.1603635091904; Sun, 25 Oct 2020 07:11:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:d8d2:0:0:0:0:0 with HTTP; Sun, 25 Oct 2020 07:11:31 -0700 (PDT) In-Reply-To: <202010251409.09PE91aS001781@repo.freebsd.org> References: <202010251409.09PE91aS001781@repo.freebsd.org> From: Oliver Pinter Date: Sun, 25 Oct 2020 15:11:31 +0100 Message-ID: Subject: Re: svn commit: r367038 - head/sbin/mount_nullfs To: Edward Tomasz Napierala Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 4CK0JP2pn4z45Zg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2020 14:11:33 -0000 On Sunday, October 25, 2020, Edward Tomasz Napierala wrote: > Author: trasz > Date: Sun Oct 25 14:09:00 2020 > New Revision: 367038 > URL: https://svnweb.freebsd.org/changeset/base/367038 > > Log: > Remove the check that prevents creating "loops" from mount_nullfs(8). > > The simple question is: why? > Reviewed by: kib > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D26921 > > Modified: > head/sbin/mount_nullfs/mount_nullfs.c > > Modified: head/sbin/mount_nullfs/mount_nullfs.c > ============================================================ > ================== > --- head/sbin/mount_nullfs/mount_nullfs.c Sun Oct 25 10:08:46 2020 > (r367037) > +++ head/sbin/mount_nullfs/mount_nullfs.c Sun Oct 25 14:09:00 2020 > (r367038) > @@ -59,7 +59,6 @@ static const char rcsid[] = > > #include "mntopts.h" > > -int subdir(const char *, const char *); > static void usage(void) __dead2; > > int > @@ -104,10 +103,6 @@ main(int argc, char *argv[]) > if (checkpath(argv[1], source) != 0) > err(EX_USAGE, "%s", source); > > - if (subdir(target, source) || subdir(source, target)) > - errx(EX_USAGE, "%s (%s) and %s are not distinct paths", > - argv[0], target, argv[1]); > - > build_iovec(&iov, &iovlen, "fstype", nullfs, (size_t)-1); > build_iovec(&iov, &iovlen, "fspath", source, (size_t)-1); > build_iovec(&iov, &iovlen, "target", target, (size_t)-1); > @@ -119,21 +114,6 @@ main(int argc, char *argv[]) > err(1, "%s", source); > } > exit(0); > -} > - > -int > -subdir(const char *p, const char *dir) > -{ > - int l; > - > - l = strlen(dir); > - if (l <= 1) > - return (1); > - > - if ((strncmp(p, dir, l) == 0) && (p[l] == '/' || p[l] == '\0')) > - return (1); > - > - return (0); > } > > static void > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >