From owner-svn-src-head@FreeBSD.ORG Wed Apr 8 20:01:07 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2725922A; Wed, 8 Apr 2015 20:01:07 +0000 (UTC) Received: from relay.mailchannels.net (si-002-i39.relay.mailchannels.net [184.154.112.204]) by mx1.freebsd.org (Postfix) with ESMTP id B3A94CD; Wed, 8 Apr 2015 20:01:05 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp2.ore.mailhop.org (ip-10-220-9-73.us-west-2.compute.internal [10.220.9.73]) by relay.mailchannels.net (Postfix) with ESMTPA id 789634DD2; Wed, 8 Apr 2015 20:00:57 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp2.ore.mailhop.org (smtp2.ore.mailhop.org [10.83.15.107]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:2500 (trex/5.4.8); Wed, 08 Apr 2015 20:00:57 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: duocircle|x-authuser|hippie X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1428523257648:2249775700 X-MC-Ingress-Time: 1428523257648 Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp2.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1Yfw9c-0003xA-C9; Wed, 08 Apr 2015 20:00:53 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t38K0Ywr004108; Wed, 8 Apr 2015 14:00:34 -0600 (MDT) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+bqIj45nPXU7htzkapSAIG Message-ID: <1428523234.82583.205.camel@freebsd.org> Subject: Re: svn commit: r281113 - head/sys/vm From: Ian Lepore To: Mateusz Guzik Date: Wed, 08 Apr 2015 14:00:34 -0600 In-Reply-To: <20150408195518.GA6086@dft-labs.eu> References: <201504051825.t35IPO7t078390@svn.freebsd.org> <20150405183947.GA24293@dft-labs.eu> <20150405185419.GA46092@dchagin.static.corbina.net> <20150408195518.GA6086@dft-labs.eu> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-AuthUser: hippie Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Chagin Dmitry X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2015 20:01:07 -0000 On Wed, 2015-04-08 at 21:55 +0200, Mateusz Guzik wrote: > On Sun, Apr 05, 2015 at 09:54:19PM +0300, Chagin Dmitry wrote: > > On Sun, Apr 05, 2015 at 08:39:47PM +0200, Mateusz Guzik wrote: > > > On Sun, Apr 05, 2015 at 06:25:24PM +0000, Dmitry Chagin wrote: > > > > Author: dchagin > > > > Date: Sun Apr 5 18:25:23 2015 > > > > New Revision: 281113 > > > > URL: https://svnweb.freebsd.org/changeset/base/281113 > > > > > > > > Log: > > > > Fix wrong kassert msg in uma. > > > > > > > > PR: 199172 > > > > Submitted by: luke.tw gmail com > > > > MFC after: 1 week > > > > > > > > Modified: > > > > head/sys/vm/uma_core.c > > > > > > > > Modified: head/sys/vm/uma_core.c > > > > ============================================================================== > > > > --- head/sys/vm/uma_core.c Sun Apr 5 17:09:58 2015 (r281112) > > > > +++ head/sys/vm/uma_core.c Sun Apr 5 18:25:23 2015 (r281113) > > > > @@ -3060,7 +3060,7 @@ uma_zone_set_fini(uma_zone_t zone, uma_f > > > > uma_keg_t keg; > > > > > > > > keg = zone_first_keg(zone); > > > > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > > > > + KASSERT(keg != NULL, ("uma_zone_set_fini: Invalid zone type")); > > > > KEG_LOCK(keg); > > > > KASSERT(keg->uk_pages == 0, > > > > ("uma_zone_set_fini on non-empty keg")); > > > > @@ -3100,7 +3100,7 @@ uma_zone_set_freef(uma_zone_t zone, uma_ > > > > uma_keg_t keg; > > > > > > > > keg = zone_first_keg(zone); > > > > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > > > > + KASSERT(keg != NULL, ("uma_zone_set_freef: Invalid zone type")); > > > > KEG_LOCK(keg); > > > > keg->uk_freef = freef; > > > > KEG_UNLOCK(keg); > > > > > > > > > > This seems to be a recurring problem (go figure). > > > > > > Was __func__ usage flamed over? > > > > > > I really think that linux's oops-like dump would be of great help here. > > > It includes file + line info along with register dump which alone can > > > give sufficient hints in several cases. > > > > > finally, kassert prints backtrace. also feel free to set > > debug.kassert.do_kdb. > > The point is to have initial user reports more useful. As it is, with > mere panic message there is not much to work with. > Have you had a problem simply grepping for the panic message string? I never have. I've used __func__ a few times to disambiguate a message where the same message string appears multiple times, but it's the rare case. -- Ian