From owner-freebsd-hackers  Sun Jan 18 13:43:53 1998
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id NAA16214
          for hackers-outgoing; Sun, 18 Jan 1998 13:43:53 -0800 (PST)
          (envelope-from owner-freebsd-hackers@FreeBSD.ORG)
Received: from red.juniper.net (red.juniper.net [208.197.169.254])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA16171;
          Sun, 18 Jan 1998 13:43:18 -0800 (PST)
          (envelope-from pst@juniper.net)
Received: from red.juniper.net (localhost.juniper.net [127.0.0.1])
	by red.juniper.net (8.8.5/8.8.5) with ESMTP id NAA08748;
	Sun, 18 Jan 1998 13:42:43 -0800 (PST)
Message-Id: <199801182142.NAA08748@red.juniper.net>
To: Bruce Evans <bde@zeta.org.au>
cc: bde@FreeBSD.ORG, dg@FreeBSD.ORG, hackers@FreeBSD.ORG
Subject: Re: isdisk() kludge in kernel 
In-reply-to: Your message of "Sun, 18 Jan 1998 14:29:57 +1100."
             <199801180329.OAA13387@godzilla.zeta.org.au> 
Date: Sun, 18 Jan 1998 13:42:42 -0800
From: Paul Traina <pst@juniper.net>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk


In message <199801180329.OAA13387@godzilla.zeta.org.au>, Bruce Evans writes:
> >I was looking at isdisk and wanted to hurl chunks.
> >
> >This is used by spec_open to determine if we should be allowed to open a
> >disk device when securelevel >= 1.
> 
> It isn't even used in -current.

I think it is, the flag gets set elsewhere.

> >I'd like to propose changing spec_open to simply NEVER allowing the open of
> >a block device, or character device, if a character device has a block
> >device associated with it and eliminate isdisk() in kern_conf entirely.
> 
> This would break at least backups to SCSI tape devices, since st has both
> block and character devices, but tapes aren't disks.  Perhaps the broken
> version is correct - isdisk() really means isasecurityholeifmountable().

Aha, you're correct, ok, bad idea.
> 
> Bruce