From nobody Thu Mar 26 14:53:37 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fhRcK0XCcz6RcWt for ; Thu, 26 Mar 2026 14:53:53 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fhRcH0KWLz3kg9 for ; Thu, 26 Mar 2026 14:53:51 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; arc=pass ("google.com:s=arc-20240605:i=1"); dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=asomers@gmail.com Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6634bb959a2so1369142a12.1 for ; Thu, 26 Mar 2026 07:53:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774536829; cv=none; d=google.com; s=arc-20240605; b=dC743bvoMQA1Y2kVOy8O59WlhnvQ1pqukHrROIFQVqqWHbwa1Re22YD71Zz265NIJa rA3XU4jLyOjvTepi6TUHv43TLCe0UKCzLpfWLJ5ijIB8pjxECR0FiAR9/jqeNa8EPnU1 aRs77ZlceJ9AgbiAzMfWPVN2jAyxPz+MQecgtgryxvdCSLNyByc1cRmfP8f1EZvx6YRT wGE0enbApvyfhMtrT0hUgIkYnF6bd/+Odk7QeTwEGiBUxQnShEkFVCe1wGAEt0UUx0hQ 5ubWcj0+d8OFD3oA/CXuBiNadOIhfgX/CnzcdnGGwxninT3KEl1RcB86obtJgPikluOF 7CfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=4f1bZFMh/gy8owIf9XIt06cs28oDgDe6Sxs19qE7l64=; fh=5dfNasj3aL0avREPGfx8vTpAPCzZGcem2ErnlDEjqkw=; b=HJbK7wEC6yD5itBpHAOyuav5qptzhv/2yFdnte4QR0sjPhkM6CneM8ioO/wdtbB40m vgBdWyi4GqY/iP8ETjZ4dRJP0bZst27Ofs4ZAVv2yVGSEeXk0n0bs4u8omx/qnOcfwUV DomGs3XtkRifgaW0hAQ3vH8sdaHwYUh2jIECvIRLBEd6FH1yaMY2j6F7lJNX65dgzErm 6pZUNjCHGU/C/LqIy6QQkc/kIAXyKNtXGdHK/VJDI9xRpWaF5vRUrk71KbElW27siZNI CDv+vy1twfaiXBjGOzVgoOey/ooX57GGDMGSnADYlb70Bzn3PO2Tm/aEDDHRoZHMwXIT jECA==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774536829; x=1775141629; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4f1bZFMh/gy8owIf9XIt06cs28oDgDe6Sxs19qE7l64=; b=XJHP4tnDReSCPVNFAOzSjwHdZWNxdkCi1b7ik/4TnTI7j7blIDhtrcENf8AYS1ObtW U4b0x91MCwujp63g60NOz5liYCCjkx5MZ4oegAMca3WGSy7JHaHBZu6vzMty1JmCk3Pk Ql2lwou3FSYACQQIUJqT955gQIeYjBt91wOZmig9F7hk+B019CafDEZrq9Dlr2QYweSM sMGPLfTFlPonXo00FAy2vZ/L1R8iwChVXUQSXV5qT44mlurpHpOF51SNha6zIUmjOW46 AHhRMPTpIroRllHII8hqnewlFtea0rcUg3zCpO0mOjr+ArLowudca0fq4/OS9CyRhVyk BBbA== X-Forwarded-Encrypted: i=1; AJvYcCUv0NU9xOLPwGO8LEQZJsMJNJ7UJ6mfy670OeNflBuLRq8c/DIVTKCXVkPRLJ7398JRWfIgSB1DOCtzG9ltbaJJ/4MHbQ==@freebsd.org X-Gm-Message-State: AOJu0YwozvLaI99ri2wgPdNr8YAbSi+CbqNGKsPDeiax5mniuQRpfmhl ZU5OyICt9x9seXczwZhAN/ZkzFlKXykJy6ZnU5IrVLFfGJmelESk4dQRIYWJSUGjidT0lFG5aad 7hcizkjGMQlNW/xuXTCy4+c8AaS0CXE8= X-Gm-Gg: ATEYQzzTW57RWix4GK2/y0OBqQs/VkXmXAVjRZV+1nxuBSp/DGYhMBfVJxNsFuv7+BP U3Iv/cut37ejjJar8aZhOO0/ojSEw8AoFndfRBTd/mE0n3oWiLVLEgmwGw/5AtMfldCUhMqTdGP Ec7NPJKoi3FLRAWnwUnW8VxJ4slEHWwrXR86pN2+6+ctbcfV68ZbysH6TXUsnFMc8L9/B7j3Sm6 RkbiH9otAinf+/N/dO97hrxb6motLWZCgXcIVkpNyNapqm+3g9Ad4BDu2KY0x1K5l1UtQiw1vjr S5qqO/dwPGnbDr+F8QBS6UJgxy4KMN9OvmO2JzQun+/Xq2HBE7aK5MYq820INDBJCbfrQtb3bE1 h8g0= X-Received: by 2002:a05:6402:348a:b0:668:502d:80c6 with SMTP id 4fb4d7f45d1cf-66a826e1cdfmr4637503a12.25.1774536829233; Thu, 26 Mar 2026 07:53:49 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202510221659.59MGxpsK054765@gitrepo.freebsd.org> In-Reply-To: <202510221659.59MGxpsK054765@gitrepo.freebsd.org> From: Alan Somers Date: Thu, 26 Mar 2026 08:53:37 -0600 X-Gm-Features: AQROBzCwKx1vn0jU2aoi85WuZ0-pTQM42HYyUyHG-CpYfhX0EsAgsfSdl2CZmUU Message-ID: Subject: Re: git: 62aef3f73f38 - main - vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller To: Gleb Popov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.98 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; NEURAL_HAM_SHORT(-0.08)[-0.084]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[asomers]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.54:from]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; MISSING_XM_UA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.54:from]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4fhRcH0KWLz3kg9 X-Spamd-Bar: -- On Wed, Oct 22, 2025 at 11:00=E2=80=AFAM Gleb Popov wr= ote: > > The branch main has been updated by arrowd: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D62aef3f73f38db9fb68bffc12c= c8900fecd58f0e > > commit 62aef3f73f38db9fb68bffc12cc8900fecd58f0e > Author: Gleb Popov > AuthorDate: 2025-07-11 07:42:09 +0000 > Commit: Gleb Popov > CommitDate: 2025-10-22 16:59:21 +0000 > > vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller > > The code that makes this VOP_BMAP call tries to perform a read-ahead = I/O > operation. Failing to do that for any reason isn't fatal for `cluster= _read()`, > because we still can return some data to the caller. This change is c= onsistent > with other places within `cluster_read()`, where error returned by VO= P_BMAP is > not returned to the caller - see the `if (nblks > 1)` block above the= changed > lines and `if (reqbp)` at the end of the function. > > PR: 264196 > Approved by: markj, kib > Differential Revision: https://reviews.freebsd.org/D51254 Shall we MFC this change? I think it affects 15.0-RELEASE.