From owner-p4-projects  Mon Jun 10 18:15:34 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A836F37B40F; Mon, 10 Jun 2002 18:15:24 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 7F3C837B404
	for <perforce@freebsd.org>; Mon, 10 Jun 2002 18:15:23 -0700 (PDT)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g5B1FNZ77304
	for perforce@freebsd.org; Mon, 10 Jun 2002 18:15:23 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Mon, 10 Jun 2002 18:15:23 -0700 (PDT)
Message-Id: <200206110115.g5B1FNZ77304@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 12678 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12678

Change 12678 by rwatson@rwatson_paprika on 2002/06/10 18:14:48

	Add some comments in places we'll need checks in the future.

Affected files ...

... //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#44 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#44 (text+ko) ====

@@ -1655,6 +1655,9 @@
 		return (error);
 	NDINIT(&nd, LOOKUP, FOLLOW | LOCKLEAF, UIO_USERSPACE,
 	    SCARG(uap, path), td);
+#ifdef MAC
+	/* XXXMAC: MAC check for chroot here. */
+#endif
 	if ((error = change_dir(&nd, td)) != 0)
 		return (error);
 	NDFREE(&nd, NDF_ONLY_PNBUF);
@@ -2232,6 +2235,11 @@
 			return (error);
 		goto restart;
 	}
+#ifdef MAC
+	/*
+	 * XXXMAC: Need some or another MAC check here.
+	 */
+#endif
 	VOP_LEASE(nd.ni_dvp, td, td->td_ucred, LEASE_WRITE);
 	error = VOP_WHITEOUT(nd.ni_dvp, &nd.ni_cnd, DELETE);
 	NDFREE(&nd, NDF_ONLY_PNBUF);
@@ -2873,6 +2881,11 @@
 		return (error);
 	NDFREE(&nd, NDF_ONLY_PNBUF);
 	vp = nd.ni_vp;
+#ifdef MAC
+	/*
+	 * XXXMAC: need some or another MAC check here.
+	 */
+#endif
 	if (vp->v_type != VLNK)
 		error = EINVAL;
 	else {

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message