Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Nov 2012 09:24:11 -0800
From:      Sean Bruno <seanbru@yahoo-inc.com>
To:        "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org>
Subject:   RE: Time to increase MAX_TASKS?
Message-ID:  <1352741051.40922.1.camel@powernoodle>
In-Reply-To: <1344884070.10417.3.camel@powernoodle.corp.yahoo.com>
References:  <1342730963.2656.5.camel@powernoodle.corp.yahoo.com> <201208071730.52899.jhb@freebsd.org> <1344382269.18854.22.camel@powernoodle.corp.yahoo.com> <201208080725.24199.jhb@freebsd.org> <1344445163.2813.2.camel@powernoodle.corp.yahoo.com> <94F2FBAB4432B54E8AACC7DFDE6C92E346B49703@ORSMSX101.amr.corp.intel.com> <1344884070.10417.3.camel@powernoodle.corp.yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2012-08-13 at 11:54 -0700, Sean Bruno wrote:
> 
> On Wed, 2012-08-08 at 10:23 -0700, Moore, Robert wrote:
> > Just FYI, we've seen the AcpiOsExecute task Q get very large if
> > There is a GPE flood that results in many, many notify operations.
> > 
> > And in these cases, it was always related to the EC (Embedded Controller).
> > 
> > Bob
> > 
> > 
> For the time being, and because I don't know what I'm doing, I've bumped
> my local freebsd9 version to use (MAX_CPU *2).
> 
> I'm sure this means something horrific is about to happen to me that I
> just don't know about yet.
> 
> Sean
> 


This seems to "do the right thing" for now, any objections?

Index: acpivar.h
===================================================================
--- acpivar.h	(revision 242921)
+++ acpivar.h	(working copy)
@@ -476,7 +476,7 @@
 
 /* Default maximum number of tasks to enqueue. */
 #ifndef ACPI_MAX_TASKS
-#define	ACPI_MAX_TASKS		32
+#define	ACPI_MAX_TASKS		MAX(32, MAXCPU * 2)
 #endif
 
 /* Default number of task queue threads to start. */





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1352741051.40922.1.camel>