From owner-svn-src-head@freebsd.org Fri Apr 14 11:56:21 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75B8ED3C40B; Fri, 14 Apr 2017 11:56:21 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward3m.cmail.yandex.net (forward3m.cmail.yandex.net [IPv6:2a02:6b8:b030::1a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F2AA53B0; Fri, 14 Apr 2017 11:56:20 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [84.201.187.144]) by forward3m.cmail.yandex.net (Yandex) with ESMTP id 76AE82130D; Fri, 14 Apr 2017 14:56:08 +0300 (MSK) Received: from smtp1h.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp1h.mail.yandex.net (Yandex) with ESMTP id E5E498C0D2D; Fri, 14 Apr 2017 14:55:54 +0300 (MSK) Received: by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id Z1Av2Xek1V-trka5dB5; Fri, 14 Apr 2017 14:55:53 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1492170953; bh=DMseF4lk8tqjZRJxC3+C8gX+YkYGl8GFQBrl8vtpOTA=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To; b=J+iqEMY5ZJH+LlLCMsEQ6cmzv2QWihDeRcjSbAquztzfxKgytfEMgMzUDioLU/HMS R+rKAyGKLNCdfLaRIiFWpy242Ikc8sHu9ohV62L6mMVmJYPA4tHKN1qIvy4YIeMghf cUTTH76YCrO8WzZSaCMq/ugfO/eE++vQHYOaDPAs= Authentication-Results: smtp1h.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-Suid-Status: 1 0,1 0,1 0,1 0 Subject: Re: svn commit: r316825 - head/sys/netpfil/ipfw To: Ed Schouten Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201704141141.v3EBf9MC097085@repo.freebsd.org> From: "Andrey V. Elsukov" Openpgp: id=E6591E1B41DA1516F0C9BC0001C5EA0410C8A17A Message-ID: <0be15fbe-ede3-804f-e844-dd75beef69ab@yandex.ru> Date: Fri, 14 Apr 2017 14:55:15 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MGD7QnffHXeINlkLRMdWm5h7vgjNVh2Be" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 11:56:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MGD7QnffHXeINlkLRMdWm5h7vgjNVh2Be Content-Type: multipart/mixed; boundary="VpFmwvFChMvEMHVqLwMkR4hVKeNccDpiX"; protected-headers="v1" From: "Andrey V. Elsukov" To: Ed Schouten Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <0be15fbe-ede3-804f-e844-dd75beef69ab@yandex.ru> Subject: Re: svn commit: r316825 - head/sys/netpfil/ipfw References: <201704141141.v3EBf9MC097085@repo.freebsd.org> In-Reply-To: --VpFmwvFChMvEMHVqLwMkR4hVKeNccDpiX Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 14.04.2017 14:52, Ed Schouten wrote: > Hi there, >=20 > 2017-04-14 13:41 GMT+02:00 Andrey V. Elsukov : >> - memcpy(&tent->k, &xn->addr6.sin6_addr, sizeof(struct i= n6_addr)); >> + memcpy(&tent->k.addr6, &xn->addr6.sin6_addr, >> + sizeof(struct in6_addr)); >=20 > In this case the code could be abbreviated by simply using assignment, = right? >=20 > tent->k.addr6 =3D xn->addr6.sin6_addr; Yes. --=20 WBR, Andrey V. Elsukov --VpFmwvFChMvEMHVqLwMkR4hVKeNccDpiX-- --MGD7QnffHXeINlkLRMdWm5h7vgjNVh2Be Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAljwuKMACgkQAcXqBBDI oXrPiAgAnu+BGS9OaGl1IgS33+keDSowl70bhtxUup2D/TKWY7Lb4aGDKFX/qsnF dNQw1xKUqGPnmKIFs9QJ6nb+uEzbBkiXbVuyDqkgBzvnt3EorKA9FL1HGMBe3AKY XpSW9T4fhZ9TzCUfmgp6hiY9jbzMb8agsOMu2QgLzZ8D/EAVMdR3wKdqeO/ZSJUe CRuyoW785Ojo4CU2HyptdVh8eA93zwXRUe+e2B8837IqHoDAayAnOgT3ivdRs/5k jMogTRRWUDSsZao9Gh4Hoao6ribg0No859deZOIevHXZ087qRRAxLSY3ISO11DlD EBBW5KnC8s9T/rdmxtUUyzN1nyqMBQ== =qy0D -----END PGP SIGNATURE----- --MGD7QnffHXeINlkLRMdWm5h7vgjNVh2Be--