From owner-freebsd-ports-bugs@freebsd.org Wed Aug 26 16:11:21 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 901C29C2B2E for ; Wed, 26 Aug 2015 16:11:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B6ECBD2 for ; Wed, 26 Aug 2015 16:11:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7QGBLTd008044 for ; Wed, 26 Aug 2015 16:11:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202404] [MAINTAINER] multimedia/mplayer2: updates to Makefile Date: Wed, 26 Aug 2015 16:11:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2015 16:11:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202404 --- Comment #24 from Jan Beich --- Comment on attachment 160377 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D160377 v7 As ffmpeg CLI isn't actually used but its libraries are BUILD_DEPENDS=3D ffmpeg:${PORTSDIR}/multimedia/ffmpeg RUN_DEPENDS=3D ffmpeg:${PORTSDIR}/multimedia/ffmpeg can be converted to LIB_DEPENDS=3D libavcodec.so:${PORTSDIR}/multimedia/ffmpeg > +OPTIONS_DEFAULT=3D ASS ENCA LIBAV X11 ENCA and LIBAV are orphaned. LIBAV_* were removed in v7 while ASS_IMPLIES=3DENCA in v6. > post-patch: > -.if ${OSVERSION} >=3D 900010 > - @${REINPLACE_CMD} -e \ > - '/CFLAGS.*-D_LARGEFILE64_SOURCE/ s/-D_LARGEFILE64_SOURCE/-D_FILE_OFFSE= T_BITS=3D64/' \ > - ${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT} > -.endif riggs@ added the substitution in ports r253004, so he should probably review its removal. I've only suggested to remove .if guard. > @@ -261,6 +174,13 @@ DEFAULT_KERN_HZ=3D${WITH_KERN_HZ} > DEFAULT_KERN_HZ=3D1024 > .endif > +.include [...] > +BROKEN_sparc64=3D Does not compile on sparc64 [...] > +CONFIGURE_ARGS+=3D --extra-libs=3D"${LIBS}" Why not concatenate value with the top CONFIGURE_ARGS definition? LIBS won't be evaluated before do-configure calls configure script after all options are already processed. > + > +# Depend on RESTRICTED package when built manually > +.if !defined(PACKAGE_BUILDING) > +OPTIONS_DEFAULT_i386+=3D WIN32 > +.endif > + Try to avoid putting anything below .include lines unless they don't work otherwise. For example, all those .if defined() expect variables defined in either environment, make.conf or command line, thus way before the port's Makefile. One exception is underdocumented Makefile.local. (In reply to Carlos J Puga Medina from comment #22) > but the main question here is keep or remove mplayer2 port. A dead project can stay in ports as long as there's a maintainer for it. Unmaintained code in libmpdemux/ and stream/ may cause a security concern but most parsing/decoding is done by ffmpeg libraries. That said, I agree about deprecation/removal as a former user of mplayer2. mpv seems like the continuation of the fast evolution of mplayer code started by Uoti. For a cooling-off period mark with DEPRECATED, otherwise use MOVED file to switch users from mplayer2 to either mpv or mplayer. DEPRECATED and EXPIRATION_DATE are invisible for package users and maybe unnoticed until periodic reminders are restored as the last one was from 2015-05-07. https://www.freebsd.org/doc/en/books/porters-handbook/dads-deprecated.html https://www.freebsd.org/doc/en/books/porters-handbook/moved-and-updating-fi= les.html#moved-and-updating-moved https://lists.freebsd.org/pipermail/freebsd-ports/2015-May/099082.html --=20 You are receiving this mail because: You are the assignee for the bug.=